From: Linus Torvalds <[email protected]>
To: Jens Axboe <[email protected]>
Cc: io-uring <[email protected]>
Subject: Re: [GIT PULL] io_uring fix for 5.11 final
Date: Fri, 12 Feb 2021 12:15:49 -0800 [thread overview]
Message-ID: <CAHk-=whB_gY_ex5CKXeVU28V-EajfRSWpAJ4aFQWrQBAC+Lc0w@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
On Fri, Feb 12, 2021 at 12:10 PM Jens Axboe <[email protected]> wrote:
>
> Right, it's exactly the AF_UNIX dgram case. Working on adding some checks
> that means we'll catch this sort of thing upfront while testing.
You might also just add a comment to the IORING_OP_{SEND,RECV}MSG
cases to the work-flags.
It doesn't hurt to just mention those kinds of things explicitly.
Because maybe somebody decides that IO_WQ_WORK_FS is very expensive
for their workload. With the comment they might then be able to say
"let's set it only for the AF_UNIX case" or some similar optimization.
Yeah, it probably doesn't matter, but just as a policy, I think "we
got this wrong, so let's clarify" is a good idea.
Linus
next prev parent reply other threads:[~2021-02-12 20:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 14:08 [GIT PULL] io_uring fix for 5.11 final Jens Axboe
2021-02-12 19:51 ` Linus Torvalds
2021-02-12 20:04 ` Jens Axboe
2021-02-12 20:07 ` Linus Torvalds
2021-02-12 20:09 ` Jens Axboe
2021-02-12 20:15 ` Linus Torvalds [this message]
2021-02-12 20:22 ` Jens Axboe
2021-02-12 20:29 ` Linus Torvalds
2021-02-12 20:42 ` Jens Axboe
2021-02-12 20:12 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=whB_gY_ex5CKXeVU28V-EajfRSWpAJ4aFQWrQBAC+Lc0w@mail.gmail.com' \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox