From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3C4BC433EF for ; Sat, 25 Sep 2021 23:05:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B2D8F60F11 for ; Sat, 25 Sep 2021 23:05:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230122AbhIYXHC (ORCPT ); Sat, 25 Sep 2021 19:07:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230078AbhIYXHB (ORCPT ); Sat, 25 Sep 2021 19:07:01 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E61DC061570 for ; Sat, 25 Sep 2021 16:05:26 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id g41so57414213lfv.1 for ; Sat, 25 Sep 2021 16:05:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sbHnE2QDsXnmv6AMlFohUnXs++TcZ00pHfdCA+ql4Xs=; b=RNbEAHUh08JhCSlAgnolE9c89iW8+i3m5LVSHfnZSePEd25ZFyjBjBA0lnCaJfcOAw jfJb/qUjXua4ANXoYKW/7/6yqK6mM8yPMb1RyNi9NGHQlrOhuhxyNLbajhERBzrsUPAQ yjcsvy0hSxEr1kwKxST/HTIXAWtGFUxVTi3sU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sbHnE2QDsXnmv6AMlFohUnXs++TcZ00pHfdCA+ql4Xs=; b=NC5HiEg0uVAggvwEpfQNaL0oSP0ge3nYSY+0eOsu/VVGaNCLf/auZhcFvhxvWgXBPJ /ICLjx++W+RClYNLzIQtcUWwXL9Me7p1RpWHFZ/6qodB6gdq3qeFkjw7K+gF2YbLvqVg FCTlpT+6+mxUmqmGR6QJj+PsH4UBO1odw28fS0QaxV/Vx8eFuJGiOUfxHmFgSlve+zPg +CebV7RRIb6W8R6IwAESJlwRcSEOGmVh0Kt72KktYJkVou4YBlqNu7ZvsSVYMsG1tk1t zP9QKvM4k5ry6eiLVjBAv+dzpMsmZcLqEXT/2KMyM14NQyJHqc4Fdqu8jMsYkw/WxF3K Z3Tw== X-Gm-Message-State: AOAM533SGy9yZJdfrAArPHK/xapdxbWEGqL4wduo9KCKirnNkaNQBssl hEjpjaD065OGwb59dGljujcxMsq2JFziXsDo X-Google-Smtp-Source: ABdhPJz4pwf/fCnz/xIbmdLRbSdSySKpKRxt/ggdvwb+IvXJYxdikBJFEltjQhQhbl4LvRLv5OvjAQ== X-Received: by 2002:ac2:4116:: with SMTP id b22mr17314209lfi.587.1632611124266; Sat, 25 Sep 2021 16:05:24 -0700 (PDT) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com. [209.85.167.42]) by smtp.gmail.com with ESMTPSA id u7sm1138067lft.79.2021.09.25.16.05.23 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Sep 2021 16:05:23 -0700 (PDT) Received: by mail-lf1-f42.google.com with SMTP id m3so57776287lfu.2 for ; Sat, 25 Sep 2021 16:05:23 -0700 (PDT) X-Received: by 2002:a05:6512:12c4:: with SMTP id p4mr17254083lfg.280.1632611123353; Sat, 25 Sep 2021 16:05:23 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Sat, 25 Sep 2021 16:05:07 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] io_uring fixes for 5.15-rc3 To: Jens Axboe , "Eric W. Biederman" , Oleg Nesterov , Al Viro Cc: io-uring Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Sat, Sep 25, 2021 at 1:32 PM Jens Axboe wrote: > > - io-wq core dump exit fix (me) Hmm. That one strikes me as odd. I get the feeling that if the io_uring thread needs to have that signal_group_exit() test, something is wrong in signal-land. It's basically a "fatal signal has been sent to another thread", and I really get the feeling that "fatal_signal_pending()" should just be modified to handle that case too. Because what about a number of other situations where we have that "killable" logic (ie "stop waiting for locks or IO if you're just going to get killed anyway" - things like lock_page_killable() and friends) Adding Eric, Oleg and Al to the participants, so that somebody else can pipe up. That piping up may quite possibly be to just tell me I'm being stupid, and that this is just a result of some io_uring thread thing, and nobody else has this problem. It's commit 87c169665578 ("io-wq: ensure we exit if thread group is exiting") in my tree. Comments? Linus