From: Linus Torvalds <[email protected]>
To: Dmitry Kadashev <[email protected]>
Cc: Jens Axboe <[email protected]>,
Alexander Viro <[email protected]>,
Christian Brauner <[email protected]>,
Pavel Begunkov <[email protected]>,
linux-fsdevel <[email protected]>,
io-uring <[email protected]>
Subject: Re: [PATCH v8 00/11] io_uring: add mkdir and [sym]linkat support
Date: Wed, 7 Jul 2021 12:26:27 -0700 [thread overview]
Message-ID: <CAHk-=wiTyxUt61NxeMXb2Zn2stDBC7eG82RKj+3jXUORdYQtpg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
On Wed, Jul 7, 2021 at 5:28 AM Dmitry Kadashev <[email protected]> wrote:
>
> This started out as an attempt to add mkdirat support to io_uring which
> is heavily based on renameat() / unlinkat() support.
Ok, sorry for having made you go through all the different versions,
but I like the new series and think it's a marked improvement.
I did send out a few comments to the individual patches that I think
it can all now be made to be even more legible by avoiding some of the
goto spaghetti, but I think that would be a series on top.
(And I'd like to note again that I based all that on just reading the
patches, so there may be something there that makes it not work well).
One final request: can you keep the fs/namei.c patches as one entirely
separate series, and then do the io_uring parts at the end, rather
than intermixing them?
But at least I am generally happy with this version.
Al - please holler now if you see any issues.
Linus
next prev parent reply other threads:[~2021-07-07 19:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 12:27 [PATCH v8 00/11] io_uring: add mkdir and [sym]linkat support Dmitry Kadashev
2021-07-07 12:27 ` [PATCH v8 01/11] namei: ignore ERR/NULL names in putname() Dmitry Kadashev
2021-07-07 12:27 ` [PATCH v8 02/11] namei: change filename_parentat() calling conventions Dmitry Kadashev
2021-07-07 19:18 ` Linus Torvalds
2021-07-07 12:27 ` [PATCH v8 03/11] fs: make do_mkdirat() take struct filename Dmitry Kadashev
2021-07-07 19:20 ` Linus Torvalds
2021-07-07 12:27 ` [PATCH v8 04/11] io_uring: add support for IORING_OP_MKDIRAT Dmitry Kadashev
2021-07-07 12:27 ` [PATCH v8 05/11] fs: make do_mknodat() take struct filename Dmitry Kadashev
2021-07-07 19:22 ` Linus Torvalds
2021-07-07 12:27 ` [PATCH v8 06/11] fs: make do_symlinkat() " Dmitry Kadashev
2021-07-07 12:27 ` [PATCH v8 07/11] namei: add getname_uflags() Dmitry Kadashev
2021-07-07 12:27 ` [PATCH v8 08/11] fs: make do_linkat() take struct filename Dmitry Kadashev
2021-07-07 12:27 ` [PATCH v8 09/11] fs: update do_*() helpers to return ints Dmitry Kadashev
2021-07-07 12:27 ` [PATCH v8 10/11] io_uring: add support for IORING_OP_SYMLINKAT Dmitry Kadashev
2021-07-07 12:27 ` [PATCH v8 11/11] io_uring: add support for IORING_OP_LINKAT Dmitry Kadashev
2021-07-07 12:32 ` [PATCH v8 00/11] io_uring: add mkdir and [sym]linkat support Dmitry Kadashev
2021-07-07 19:26 ` Linus Torvalds [this message]
2021-07-08 6:05 ` Dmitry Kadashev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wiTyxUt61NxeMXb2Zn2stDBC7eG82RKj+3jXUORdYQtpg@mail.gmail.com' \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox