From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03873184131 for ; Wed, 3 Jul 2024 17:09:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720026576; cv=none; b=ZugE8BHsoqFRgM1bQJ6J8MtVSlSG6daA4VNXP8LFS6E4d3vdWfCTk7modDz7/uFt22lzXE8QfniiZZg7c8m1qIPU5ggZBrFhpkvJ54BtosRMabqdNs/4ZHzN4Lvf2Nnw8rRetsarRkmEual70F2mbeTgnSleM4G+GhyjukDubFE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720026576; c=relaxed/simple; bh=uRU/MzlOzw7CmWbyItl0EyiCdZwjkjyxkrbpjs0FjXU=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=OEVAQUDnFgbIlz8QWcChgKExDY8qnWnSfjh39fnhaKlps6tvrA2lsttWzUPjnVpCImxtvKCnVLGYlUn9AVe10ZVgpg6QQNOre2ERzSSvtha2B77Ow1GgIywpi+8GVgKgGIJGPGHVDBqyNm1282QWYub1b47YYdb0MZfX2Gc1OO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=NbBCcupb; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="NbBCcupb" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-52e9944764fso934231e87.3 for ; Wed, 03 Jul 2024 10:09:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1720026573; x=1720631373; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kRpbCtw/E4IRbKxwJt2blPeYec2wEFVPadTklw6HsWc=; b=NbBCcupblJu4PVrUIvbbrMLbkzfHUFV1a1ICLrJQwWkFgPp3gTk5dYD+x7ICrix5NY kuvfH8lDBhfW7akW8dhbntdgiDzS13yG/D7n88brLwWhmWVT/Ql9uBPy9kZLRsskvYIL t+A0rPsRghA70DjGHxlqlNiSxomWhEkhkrylw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720026573; x=1720631373; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kRpbCtw/E4IRbKxwJt2blPeYec2wEFVPadTklw6HsWc=; b=FREA1zEvxFiDO4IDeRFabc/qATHV70cUoVtuNOR9E98iAeb3Up2hqqZ3z29f3Tqlx9 tR98kvdeZzah0mcMejBPLn3KgFkwMSR4mYBOFwKZvyEwralA6cCzmokfpM3H9LYtEdaq TvdZ4r7QZtbM6XENLwO9bJkqpfXarCZhDTusiASIYk9KqE2Jkh+ot7Nx/fOXYT+dRPBO B09Ka/fJkwWxkUzJkD4adP6cHZ9murFBVeG/wjIA7zzTlOjRfPvRT2LRq2jdrnre0HDe X9ybYZk/zPkhgLdp1u/nvUdGT1rddomYooIPigl9zTWcuCNTB5MS8Rvlxll9TPTsCXAv BW5w== X-Forwarded-Encrypted: i=1; AJvYcCXiqLSJvNPiBh3GjnJxUWMVqijHZ013R1oR4KL1CD/v6uEVdQrFJCm0jekABtpk9GmlbjV4CeAGLnnuuo8uwt/IK4OoMr3x3tY= X-Gm-Message-State: AOJu0YzxWONvYyaFJX+lCCCwkaufWXvdxJpNM8HuyqLHHO514QrMdelh GWlClRsyKjhqQCYRV1U/tkIlp++LR1sU3sfFEMoCGCFg7k2jn0l99usgA6xNKWWfKx9s/yfeY9I m3mELcg== X-Google-Smtp-Source: AGHT+IEUfFycHVsgij+mPMbSAH9pcouqcgku7v8Gduop5TqadWNWL0tZoVWFK2fLaC6/sPdLMu8SPg== X-Received: by 2002:a05:6512:3c9f:b0:52e:7a8c:35a0 with SMTP id 2adb3069b0e04-52e82651c44mr10295532e87.7.1720026572858; Wed, 03 Jul 2024 10:09:32 -0700 (PDT) Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com. [209.85.218.41]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72ab065241sm525678966b.108.2024.07.03.10.09.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jul 2024 10:09:32 -0700 (PDT) Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a6fd513f18bso747935466b.3 for ; Wed, 03 Jul 2024 10:09:31 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCW9OLpGZ/NZg0biOP7TraU+DsAp1flF3H8DwLeAKyXSwONa6EPwY7EYWbPdjspaBvn4aEfP//61EfaAGjcSrv7wxpBzsX4HZoQ= X-Received: by 2002:a17:906:f756:b0:a72:42b8:257c with SMTP id a640c23a62f3a-a751444c4b3mr853732366b.35.1720026571539; Wed, 03 Jul 2024 10:09:31 -0700 (PDT) Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240625110029.606032-1-mjguzik@gmail.com> <20240625110029.606032-3-mjguzik@gmail.com> <30907b42d5eee6d71f40b9fc3d32ae31406fe899.camel@xry111.site> <1b5d0840-766b-4c3b-8579-3c2c892c4d74@app.fastmail.com> <8f2d356d-9cd6-4b06-8e20-941e187cab43@app.fastmail.com> <20240703-bergwacht-sitzung-ef4f2e63cd70@brauner> <8b6d59ffc9baa57fee0f9fa97e72121fd88cf0e4.camel@xry111.site> In-Reply-To: <8b6d59ffc9baa57fee0f9fa97e72121fd88cf0e4.camel@xry111.site> From: Linus Torvalds Date: Wed, 3 Jul 2024 10:09:15 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] vfs: support statx(..., NULL, AT_EMPTY_PATH, ...) To: Xi Ruoyao Cc: Christian Brauner , libc-alpha@sourceware.org, "Andreas K. Huettel" , Arnd Bergmann , Huacai Chen , Mateusz Guzik , Alexander Viro , Jan Kara , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, Jens Axboe , loongarch@lists.linux.dev Content-Type: text/plain; charset="UTF-8" On Wed, 3 Jul 2024 at 09:54, Xi Ruoyao wrote: > > > Honestly, 'statx' is disgusting. I don't understand why anybody pushes > > that thing that nobody actually uses or cares about. > > Hmm why it was added in the first place then? Why not just NAK it? There are valid uses of statx - they are just VERY very few and far between. For example, if you want the "change cookie" or any number of other special things that aren't standard, you have to use statx. But _normal_ programs will never do that. It's unportable, and it really is a specialty interface. Pushing 'statx' as a replacement for 'stat' is just crazy. It's a different thing. It's not a "better" thing. It's an extension, yes, but "extension" doesn't mean "better". That's true when it was mis-designed in certain ways that we now have to fix up, but PARTICULARLY true when it's nonstandard and no other OS has it. > And should we add stat_time64, fstat_time64, and fstatat_time64 to stop > using statx on 32-bit platforms too as it's disgusting? We already have 'stat64' for 32-bit platforms. We have had it for over 25 years - it predates not only the kernel git tree, it predates the BK tree too. I think stat64 was introduced in 2.3.34. That is literally last century. Anybody who tries to make this about 2037 is being actively dishonest. Why are people even discussing this pointless thing? Linus