From: Linus Torvalds <[email protected]>
To: "Eric W. Biederman" <[email protected]>
Cc: Jens Axboe <[email protected]>, io-uring <[email protected]>,
Linux Kernel Mailing List <[email protected]>,
Oleg Nesterov <[email protected]>,
Stefan Metzmacher <[email protected]>
Subject: Re: [PATCH 1/2] signal: don't allow sending any signals to PF_IO_WORKER threads
Date: Sat, 20 Mar 2021 10:56:36 -0700 [thread overview]
Message-ID: <CAHk-=wjLMy+J20ZSBec4iarw2NeSu5sWXm6wdMH59n-e0Qe06g@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
On Sat, Mar 20, 2021 at 9:19 AM Eric W. Biederman <[email protected]> wrote:
>
> The creds should be reasonably in-sync with the rest of the threads.
It's not about credentials (despite the -EPERM).
It's about the fact that kernel threads cannot handle signals, and
then get caught in endless loops of "if (sigpending()) return
-EAGAIN".
For a normal user thread, that "return -EAGAIN" (or whatever) will end
up returning an error to user space - and before it does that, it will
go through the "oh, returning to user space, so handle signal" path.
Which will clear sigpending etc.
A thread that never returns to user space fundamentally cannot handle
this. The sigpending() stays on forever, the signal never gets
handled, the thread can't do anything.
So delivering a signal to a kernel thread fundamentally cannot work
(although we do have some threads that explicitly see "oh, if I was
killed, I will exit" - think things like in-kernel nfsd etc).
Linus
next prev parent reply other threads:[~2021-03-20 17:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 15:38 [PATCHSET 0/2] PF_IO_WORKER signal tweaks Jens Axboe
2021-03-20 15:38 ` [PATCH 1/2] signal: don't allow sending any signals to PF_IO_WORKER threads Jens Axboe
2021-03-20 16:18 ` Eric W. Biederman
2021-03-20 17:56 ` Linus Torvalds [this message]
2021-03-20 21:38 ` Eric W. Biederman
2021-03-20 22:42 ` Jens Axboe
2021-03-21 14:54 ` Eric W. Biederman
2021-03-21 15:40 ` Jens Axboe
2021-03-20 15:38 ` [PATCH 2/2] signal: don't allow STOP on " Jens Axboe
2021-03-20 16:21 ` Eric W. Biederman
2021-03-22 16:18 ` Oleg Nesterov
2021-03-22 16:15 ` Oleg Nesterov
2021-03-20 16:26 ` [PATCHSET 0/2] PF_IO_WORKER signal tweaks Eric W. Biederman
2021-03-20 17:51 ` Linus Torvalds
2021-03-20 19:18 ` Linus Torvalds
2021-03-20 22:08 ` Eric W. Biederman
2021-03-20 22:53 ` Jens Axboe
2021-03-21 15:18 ` Eric W. Biederman
2021-03-21 15:42 ` Jens Axboe
2021-03-20 22:56 ` Jens Axboe
2021-03-20 17:05 ` kernel test robot
2021-03-20 17:05 ` kernel test robot
2021-03-20 19:10 ` kernel test robot
2021-03-22 16:05 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wjLMy+J20ZSBec4iarw2NeSu5sWXm6wdMH59n-e0Qe06g@mail.gmail.com' \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox