From: Linus Torvalds <[email protected]>
To: Jens Axboe <[email protected]>
Cc: io-uring <[email protected]>
Subject: Re: [GIT PULL] io_uring fixes for 5.12-rc3
Date: Fri, 12 Mar 2021 13:17:12 -0800 [thread overview]
Message-ID: <CAHk-=wjpS-kwozJQFNBestco=q5j3bcfXpVXc6uz=9_mmQ7oYg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
On Fri, Mar 12, 2021 at 11:48 AM Jens Axboe <[email protected]> wrote:
>
> - Make IO threads unfreezable by default, on account of a bug report
> that had them spinning on resume. Honestly not quite sure why thawing
> leaves us with a perpetual signal pending (causing the spin), but for
> now make them unfreezable like there were in 5.11 and prior.
That "not quite sure" doesn't exactly give my the warm and fuzzies,
but not being new is ok, I guess. But I'd really like you to try to
figure out what is actually going on.
I'm _guessing_ it's just that now those threads are user threads, and
then the freezing logic expects them to freeze/thaw using a signal
machinery or something like that. And that doesn't work when there is
no signal handling for those threads.
But it would be good to _know_.
Linus
next prev parent reply other threads:[~2021-03-12 21:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 19:48 [GIT PULL] io_uring fixes for 5.12-rc3 Jens Axboe
2021-03-12 21:17 ` Linus Torvalds [this message]
2021-03-12 21:24 ` Linus Torvalds
2021-03-12 21:25 ` Linus Torvalds
2021-03-12 21:34 ` Linus Torvalds
2021-03-12 21:35 ` Jens Axboe
2021-03-12 21:33 ` Jens Axboe
2021-03-12 21:31 ` Jens Axboe
2021-03-12 21:52 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wjpS-kwozJQFNBestco=q5j3bcfXpVXc6uz=9_mmQ7oYg@mail.gmail.com' \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox