public inbox for [email protected]
 help / color / mirror / Atom feed
From: Miklos Szeredi <[email protected]>
To: Stefan Roesch <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: [PATCH v1 1/3] fs: add parameter use_fpos to iterate_dir function
Date: Thu, 25 Nov 2021 15:45:43 +0100	[thread overview]
Message-ID: <CAJfpegsusDTYwRm5ig-EnvG0c5vqCRozuj34YcbTAD1kqi02Cg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>

On Tue, 23 Nov 2021 at 19:10, Stefan Roesch <[email protected]> wrote:
>
> This adds the use_fpos parameter to the iterate_dir function.
> If use_fpos is true it uses the file position in the file
> structure (existing behavior). If use_fpos is false, it uses
> the pos in the context structure.

Is there a reason not to introduce a iterate_dir_no_fpos() variant and
call this from iterate_dir() with the necessary fpos update?

Thanks,
Miklos

  parent reply	other threads:[~2021-11-25 14:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23 18:10 [PATCH v1 0/3] io_uring: add getdents64 support Stefan Roesch
2021-11-23 18:10 ` [PATCH v1 1/3] fs: add parameter use_fpos to iterate_dir function Stefan Roesch
2021-11-24 19:58   ` kernel test robot
2021-11-25 14:45   ` Miklos Szeredi [this message]
2021-11-25 23:18     ` Stefan Roesch
2021-11-25 15:47   ` Pavel Begunkov
2021-11-25 23:17     ` Stefan Roesch
2021-11-25 15:55   ` Pavel Begunkov
2021-11-25 23:19     ` Stefan Roesch
2021-11-23 18:10 ` [PATCH v1 2/3] fs: split off vfs_getdents function of getdents64 syscall Stefan Roesch
2021-11-26 10:53   ` Christian Brauner
2021-11-23 18:10 ` [PATCH v1 3/3] io_uring: add support for getdents64 Stefan Roesch
2021-11-25 15:41   ` Pavel Begunkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJfpegsusDTYwRm5ig-EnvG0c5vqCRozuj34YcbTAD1kqi02Cg@mail.gmail.com \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox