From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <io-uring-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 23BDEC433F5
	for <io-uring@archiver.kernel.org>; Thu, 25 Nov 2021 14:47:56 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1355939AbhKYOvG (ORCPT <rfc822;io-uring@archiver.kernel.org>);
        Thu, 25 Nov 2021 09:51:06 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35932 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1351240AbhKYOtG (ORCPT
        <rfc822;io-uring@vger.kernel.org>); Thu, 25 Nov 2021 09:49:06 -0500
Received: from mail-ua1-x92d.google.com (mail-ua1-x92d.google.com [IPv6:2607:f8b0:4864:20::92d])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23C05C061574
        for <io-uring@vger.kernel.org>; Thu, 25 Nov 2021 06:45:55 -0800 (PST)
Received: by mail-ua1-x92d.google.com with SMTP id ay21so12739394uab.12
        for <io-uring@vger.kernel.org>; Thu, 25 Nov 2021 06:45:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=szeredi.hu; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=mtbCZM95cRfzM9aIhXBEhEk5A8jIBT2rwACHIginNKY=;
        b=EVvcs3MITFAwnudiT6UELc0/nNTrSpSghYDRSz7bPTNkJmfVvEysWN205k1mT8ZATV
         9dfqTYPGwVoq+jPXUK8p7lrMjKDNJrB7EPGceWnReRmTugzp1NrbZ04bQMyCSoCxOJzL
         9wMSDoX8Vu2OVgDTERvxtxz1/5jQJEJYX5cLE=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=mtbCZM95cRfzM9aIhXBEhEk5A8jIBT2rwACHIginNKY=;
        b=LYfuirJYXGirYP7UjfaplZcyTTivd9IwRGkMPRFlL15uoZKnOStLcG3E+KXSabB5Fu
         Q4iBjBo2mGKosEFHiyG+L939dQklzhUShq/M3h9N4PSRkGdxxvuIIX7nR7DRc/si69gY
         DTriZTWjn6XOUTofDknEGuBVhy80An5cGRPSsE8owLEdSM26L5KHPKvTZjbFv8MWZWdF
         9KU35S8NUJl39FO/EoZhXCXa+maM8gPQTXLoNga1qBvBnbE1oh7RZQiQSfdhKk3tKgJm
         HqXuTjqhU6BUF22FZVqSJBfukr6PfIkP7IBP8Pt7+INYAXItByhdZcJLfFgf4ivyn7qm
         YQoQ==
X-Gm-Message-State: AOAM532IxwOXIzkYQQu7RkfJ5ALYVoMEYuv3J2GkLopghIbO/uhUuz/d
        D7KBjtm8ghLaF7ebPamhDB7gfg1rfHqGA/mYYx9dCA==
X-Google-Smtp-Source: ABdhPJzsKp26qJGleQ9bj5NtBPIH4TdxPWgzVihb78G4ztFNLkCa0S2G/7avPfnXaOOnRjdaLws3v0hcEtwm4dSsT1Q=
X-Received: by 2002:a05:6102:945:: with SMTP id a5mr9771107vsi.87.1637851554336;
 Thu, 25 Nov 2021 06:45:54 -0800 (PST)
MIME-Version: 1.0
References: <20211123181010.1607630-1-shr@fb.com> <20211123181010.1607630-2-shr@fb.com>
In-Reply-To: <20211123181010.1607630-2-shr@fb.com>
From:   Miklos Szeredi <miklos@szeredi.hu>
Date:   Thu, 25 Nov 2021 15:45:43 +0100
Message-ID: <CAJfpegsusDTYwRm5ig-EnvG0c5vqCRozuj34YcbTAD1kqi02Cg@mail.gmail.com>
Subject: Re: [PATCH v1 1/3] fs: add parameter use_fpos to iterate_dir function
To:     Stefan Roesch <shr@fb.com>
Cc:     io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
List-ID: <io-uring.vger.kernel.org>
X-Mailing-List: io-uring@vger.kernel.org

On Tue, 23 Nov 2021 at 19:10, Stefan Roesch <shr@fb.com> wrote:
>
> This adds the use_fpos parameter to the iterate_dir function.
> If use_fpos is true it uses the file position in the file
> structure (existing behavior). If use_fpos is false, it uses
> the pos in the context structure.

Is there a reason not to introduce a iterate_dir_no_fpos() variant and
call this from iterate_dir() with the necessary fpos update?

Thanks,
Miklos