From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0064D17C61 for ; Mon, 25 Nov 2024 15:34:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732548888; cv=none; b=ehOdxI8xg1Ehe7HnL2vhS0M0HQRsEnfy8zggSR0/QystltjW4QlcwTDDnjrtS/f3ciXzpXAG3qbDlTTtk68fX3W/INfXoQrH4XLRDIooDd2WZEhOFjvQtTItjMj01rXWWgNf8povTywbHthJ/NI8ufo7mO+xlbPldb4/MA8gTFA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732548888; c=relaxed/simple; bh=86nOUeUagQJ2k/h5shMlidVE6VHGCZdOo0proGfjevI=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Kw5JlmTZ54b2aC1kYI7xxw2Y2dxHU7b/ff5UlRxA4RLTzWlXsosAEqrh5qvMSP8jWilZA5gckv8H2/8YjemJp8964qbly+LDEkYFHKBy10whtJUaT7deKcghUkK5GlxaQJGXci9057mKGSuUaqP1JDL41eXY698JTfoJ9vW64x0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=szeredi.hu; spf=pass smtp.mailfrom=szeredi.hu; dkim=pass (1024-bit key) header.d=szeredi.hu header.i=@szeredi.hu header.b=OfsNQbt7; arc=none smtp.client-ip=209.85.160.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=szeredi.hu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=szeredi.hu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=szeredi.hu header.i=@szeredi.hu header.b="OfsNQbt7" Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-4668f208f5fso9968311cf.0 for ; Mon, 25 Nov 2024 07:34:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; t=1732548886; x=1733153686; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=86nOUeUagQJ2k/h5shMlidVE6VHGCZdOo0proGfjevI=; b=OfsNQbt75Y92G90NPfYCwQIfl+3mg/HRedxfuTOuyEYNVC3yADlppMzKWg6br4qoW2 8EY1JowPBEROFAHhq/zTzGBuZ+V2jBjkpCeRebKs8mRnknJ7Y+obK0HAr7ijJFA4xAjV JXq49DJjMmjIZgbfJ63qh5rDk0sN/NiTIBWkI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732548886; x=1733153686; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=86nOUeUagQJ2k/h5shMlidVE6VHGCZdOo0proGfjevI=; b=hGFoOZznX2cWCU/W81TjdZ9saMmgV6vPbvG8Q0A9hnB0hupfWTpUj2F1UIwhGRz/xT Yi7A6J0vUCzsYqw0RqcESoMmaVADEdtKx3Qgwz/pHgBqaCR60kgUZhK/Px1/LB1Z9Isi WujP527du5pr2FInQtgtdqBZqhJFpgg65Tvwx3lq7z6UguMqxaOfRFWAbhIriq5wAsBm FMObrussiMzqH0ZIdzY2K++UkoJlSlduG7FAwj36gMKmGm/ihibWAPsR4ZucEPCOMzK0 s+d/SrRQlv7BDKC5EFrml7oJpa7uhNP8b3vPl6JvEx8tHM8atc/yCbB4TYofFoBgFQFQ LSYQ== X-Forwarded-Encrypted: i=1; AJvYcCVmnrqkO9bM8Q+hulG0ltHknZmqvGfd5xTrVethIZaQHrJ1VCg0JmF5Py1cQK3SNLvRhgTUSM2AJw==@vger.kernel.org X-Gm-Message-State: AOJu0Yysb8fQhGPUrm3rQspZJpH60UsQSbSYNZ5aVtAst6KXdvUwc9Of rbJFSeNH10YZSwcMSJB2G5t41ztGT2jSyemN9Lk3g8SbWRGEfuK2PUhIIPxCw+Xhol1OeQPZ87I 6EvJugi9SjInXT+2x9ootcvp9pAgkih766E00wQ== X-Gm-Gg: ASbGncvERqGNagmdJ8w0xHR4rzkeJm5QwIVlx0WOeKlVnNUX9n8g1Jl5db5naHaAL6c N6TYDN7qU49q1rUVrwOIVR+ecmwDVMVCi7g== X-Google-Smtp-Source: AGHT+IEa8TehfeXB1Kg5BxElG/ZzztNpk45tPPXLV7SWp4eBM8bxfkmfKbGitCLixO+1HWeTBCGI/yZEmiS8+6bwsk8= X-Received: by 2002:a05:622a:1807:b0:461:6aa9:9479 with SMTP id d75a77b69052e-4653d631425mr152114451cf.53.1732548886013; Mon, 25 Nov 2024 07:34:46 -0800 (PST) Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20241122-fuse-uring-for-6-10-rfc4-v6-0-28e6cdd0e914@ddn.com> <20241122-fuse-uring-for-6-10-rfc4-v6-5-28e6cdd0e914@ddn.com> <6876e1cf-9bd2-483d-bd49-c52967c88397@fastmail.fm> In-Reply-To: <6876e1cf-9bd2-483d-bd49-c52967c88397@fastmail.fm> From: Miklos Szeredi Date: Mon, 25 Nov 2024 16:34:35 +0100 Message-ID: Subject: Re: [PATCH RFC v6 05/16] fuse: make args->in_args[0] to be always the header To: Bernd Schubert Cc: Bernd Schubert , Jens Axboe , Pavel Begunkov , linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, Joanne Koong , Josef Bacik , Amir Goldstein , Ming Lei , David Wei , bernd@bsbernd.com Content-Type: text/plain; charset="UTF-8" On Mon, 25 Nov 2024 at 15:46, Bernd Schubert wrote: > I have to remove the WARN_ON_ONCE condition altogether, gets triggered by > /dev/fuse read (i.e. with io-uring being disabled), in generic/062, > op code=39 (FUSE_IOCTL). > Without the pr_err_once() and printing the op code it would have been impossible > to see which op code that is - the trace does not help here. It should, since commit 396b209e405a ("fuse: add simple request tracepoints"). Thanks, Miklos