public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Joanne Koong <joannelkoong@gmail.com>
To: Pavel Begunkov <asml.silence@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	axboe@kernel.dk, io-uring@vger.kernel.org,
	 csander@purestorage.com, krisman@suse.de, bernd@bsbernd.com,
	 linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v1 03/11] io_uring/kbuf: add support for kernel-managed buffer rings
Date: Fri, 20 Feb 2026 18:14:28 -0800	[thread overview]
Message-ID: <CAJnrk1Zr=9RMGpNXpe6=fSDkG2uVijB9qa1vENHpQozB3iPQtg@mail.gmail.com> (raw)
In-Reply-To: <11869d3d-1c40-4d49-a6c2-607fd621bf91@gmail.com>

On Fri, Feb 20, 2026 at 4:53 AM Pavel Begunkov <asml.silence@gmail.com> wrote:
>
> On 2/18/26 21:43, Joanne Koong wrote:
> > On Wed, Feb 18, 2026 at 4:36 AM Pavel Begunkov <asml.silence@gmail.com> wrote:
> >>
> >> On 2/13/26 22:04, Joanne Koong wrote:
> >>> On Fri, Feb 13, 2026 at 4:41 AM Pavel Begunkov <asml.silence@gmail.com> wrote:
> >> ...
> >>>> Fuse is doing both adding (kernel) buffers to the ring and consuming
> >>>> them. At which point it's not clear:
> >>>>
> >>>> 1. Why it even needs io_uring provided buffer rings, it can be all
> >>>>       contained in fuse. Maybe it's trying to reuse pbuf ring code as
> >>>>       basically an internal memory allocator, but then why expose buffer
> >>>>       rings as an io_uring uapi instead of keeping it internally.
> >>>>
> >>>>       That's also why I mentioned whether those buffers are supposed to
> >>>>       be used with other types of io_uring requests like recv, etc.
> >>>
> >>> On the userspace/server side, it uses the buffers for other io-uring
> >>> operations (eg reading or writing the contents from/to a
> >>> locally-backed file).
> >>
> >
> > Sorry, I submitted v2 last night thinking the conversation on this
> > thread had died. After reading through your reply, I'll modify v2.
>
> No worries at all, and sorry I'm a bit slow to reply
>
> >> Oops, typo. I was asking whether the buffer rings (not buffers) are
> >> supposed to be used with other requests. E.g. submitting a
> >> IORING_OP_RECV with IOSQE_BUFFER_SELECT set and the bgid specifying
> >> your kernel-managed buffer ring.
> >
> > Yes the buffer rings are intended to be used with other io-uring
> > requests. The ideal scenario is that the user can then do the
> > equivalent of IORING_OP_READ/WRITE_FIXED operations on the
> > kernel-managed buffers and avoid the per-i/o page pinning overhead
> > costs.
>
> You mention OP_READ_FIXED and below agreed not exposing km rings
> an io_uring uapi, which makes me believe we're still talking about
> different things.
>
> Correct me if I'm wrong. Currently, only fuse cmds use the buffer
> ring itself, I'm not talking about buffer, i.e. fuse cmds consume
> entries from the ring (!!! that's the part I'm interested in), then
> process them and tell the server "this offset in the region has user
> data to process or should be populated with data".
>
> Naturally, the server should be able to use the buffers to issue
> some I/O and process it in other ways, whether it's a normal
> OP_READ to which you pass the user space address (you can since
> it's mmap()'ed by the server) or something else is important but
> a separate question than the one I'm trying to understand.
>
> So I'm asking whether you expect that a server or other user space
> program should be able to issue a READ_OP_RECV, READ_OP_READ or any
> other similar request, which would consume buffers/entries from the
> km ring without any fuse kernel code involved? Do you have some
> use case for that in mind?

Thanks for clarifying your question. Yes, this would be a useful
optimization in the future for fuse servers with certain workload
characteristics (eg network-backed servers with high concurrency and
unpredictable latencies). I don't think the concept of kmbufrings is
exclusively fuse-specific though (for example, Christoph's use case
being a recent instance); I think other subsystems/users that'll use
kmbuf rings would also generically find it useful to have the option
of READ_OP_RECV/READ_OP_READ operating directly on the ring.

>
> Understanding that is the key in deciding whether km rings should
> be exposed as io_uring uapi or not, regardless of where buffers
> to populate the ring come from.
>
> ...
> > With it going through a mem region, I don't think it should even go
> > through the "pbuf ring" interface then if it's not going to specify
> > the number of entries and buffer sizes upfront, if support is added
> > for io-uring normal requests (eg IORING_OP_READ/WRITE) to use the
> > backing pages from a memory region and if we're able to guarantee that
> > the registered memory region will never be able to be unregistered by
> > the user. I think if we repurpose the
> >
> > union {
> >    __u64 addr; /* pointer to buffer or iovecs */
> >    __u64 splice_off_in;
> > };
> >
> > fields in the struct io_uring_sqe to
> >
> > union {
> >    __u64 addr; /* pointer to buffer or iovecs */
> >    __u64 splice_off_in;
> >    __u64 offset; /* offset into registered mem region */
> > };
> >
> > and add some IOSQE_ flag to indicate it should find the pages from the
> > registered mem region, then that should work for normal requests.
> > Where on the kernel side, it looks up the associated pages stored in
> > the io_mapped_region's pages array for the offset passed in.
>
> So you already can do all that using the mmap()'ed region user
> pointer, and you just want it to be more efficient, right?
> For that let's just reuse registered buffers, we don't need a
> new mechanism that needs to be propagated to all request types.
> And registered buffer are already optimised for I/O in a bunch
> of ways. And as a bonus, it'll be similar to the zero-copy
> internally registered buffers if you still plan to add them.
>
> The simplest way to do that is to create a registered buffer out
> of the mmap'ed region pointer. Pseudo code:
>
> // mmap'ed if it's kernel allocated.
> {region_ptr, region_size} = create_region();
>
> struct iovec iov;
> iov.iov_base = region_ptr;
> iov.iov_len = region_size;
> io_uring_register_buffers(ring, &iov, 1);
>
> // later instead of this:
> ptr = region_ptr + off;
> io_uring_prep_read(sqe, fd, ptr, ...);
>
> // you use registered buffers as usual:
> io_uring_prep_read_fixed(sqe, fd, off, regbuf_idx, ...);
>

I feel like this design makes the interface more convoluted and now
muddies different concepts together by adding new complexity /
relationships between them whereas they were otherwise cleanly
isolated. Maybe I'm just not seeing/understanding the overarching
vision for why conceptually it makes sense for them to be tied
together besides as a mechanism to tell io-uring requests where to
copy from by reusing what exists for fixed buffer ids. There's more
complexity now on the kernel side (eg having to detect if the buffer
passed in is kernel-allocated to know whether to pin the pages /
charge it against the user's RLIMIT_MEMLOCK limit) but I'm not
understanding what we gain from it. I got the sense from your previous
comments that memory regions are the de facto way to go and should be
decoupled from other structures, so if that's the case, why doesn't it
make sense for io-uring to add native support for using memory regions
for io-uring requests? I feel like from the userspace side it makes
things more confusing with this extra layer of indirection that now
has to go through a fixed buffer.

>
> IIRC the registration would fail because it doesn't allow file
> backed pages, but it should be fine if we know it's io_uring
> region memory, so that would need to be patched.
>
> There might be a bunch of other ways you can do that like
> create a kernel allocated registered buffer like what Cristoph
> wants, and then register it as a region. Or allow creating
> registered buffers out of a region. etc.
>
> I wanted to unify registered buffers and regions internally
> at some point, but then drifted away from active io_uring core
> infrastructure development, so I guess that could've been useful.
>
> > Right now there's only a uapi to register a memory region and none to
> > unregister one. Is it guaranteed that io-uring will never add
> > something in the future that will let userspace unregister the memory
> > region or at least unregister it while it's being used (eg if we add
> > future refcounting to it to track active uses of it)?
>
> Let's talk about it when it's needed or something changes, but if
> you do registered buffers instead as per above, they'll be holding
> page references and or have to pin the region in some other way.

I don't think we can guarantee that the caller will register the
memory region as a fixed buffer (eg if it doesn't need/want to use the
buffer for normal io-uring requests). On the kernel side, the internal
buffer entry uses the kaddr of the registered memory region buffer for
any memcpys. If it's not guaranteed that registered memory regions
persist for the lifetime of the ring, there'll have to be extra
overhead for every I/O (eg grab the io-uring lock, checking if the mem
region is still registered, grab a refcount to that mem region, unlock
the ring, do the memcpy to the kaddr, then grab the io-uring lock
again, decrement the refcount, and unlock). Or I guess we could add
pinning to a registered memory region.

Thanks,
Joanne
>
> > If so, then end-to-end, with it going through the mem region, it would
> > be something like:
> > * user creates a mem region for the io-uring
> > * user mmaps the mem region
>
> FWIW, we should just add a liburing helper, so that fuse server
> doesn't need to deal with mmap'ing.
>
> > * user passes in offset into region, length of each buffer, and number
> > of entries in the ring to the subsystem
> > * subsystem creates a locally managed bufring and adds buffers to that
> > ring from the mem region
>
> That's sounds clean to me _if_ it allows you to achieve all
> (fast path) optimisations you want to have. I hope it does?
>
> --
> Pavel Begunkov
>

  reply	other threads:[~2026-02-21  2:14 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10  0:28 [PATCH v1 00/11] io_uring: add kernel-managed buffer rings Joanne Koong
2026-02-10  0:28 ` [PATCH v1 01/11] io_uring/kbuf: refactor io_register_pbuf_ring() logic into generic helpers Joanne Koong
2026-02-10  0:28 ` [PATCH v1 02/11] io_uring/kbuf: rename io_unregister_pbuf_ring() to io_unregister_buf_ring() Joanne Koong
2026-02-10  0:28 ` [PATCH v1 03/11] io_uring/kbuf: add support for kernel-managed buffer rings Joanne Koong
2026-02-10 16:34   ` Pavel Begunkov
2026-02-10 19:39     ` Joanne Koong
2026-02-11 12:01       ` Pavel Begunkov
2026-02-11 22:06         ` Joanne Koong
2026-02-12 10:07           ` Christoph Hellwig
2026-02-12 10:52             ` Pavel Begunkov
2026-02-12 17:29               ` Joanne Koong
2026-02-13  7:27                 ` Christoph Hellwig
2026-02-13 15:31                   ` Pavel Begunkov
2026-02-13 15:48                     ` Pavel Begunkov
2026-02-13 19:09                     ` Joanne Koong
2026-02-13 19:30                       ` Bernd Schubert
2026-02-13 19:38                         ` Joanne Koong
2026-02-17  5:36                       ` Christoph Hellwig
2026-02-13 19:14                   ` Joanne Koong
2026-02-17  5:38                     ` Christoph Hellwig
2026-02-18  9:51                       ` Pavel Begunkov
2026-02-13 16:27                 ` Pavel Begunkov
2026-02-13  7:21               ` Christoph Hellwig
2026-02-13 13:18                 ` Pavel Begunkov
2026-02-13 15:26           ` Pavel Begunkov
2026-02-27  1:12           ` Joanne Koong
2026-02-27 20:48             ` Pavel Begunkov
2026-03-02 20:50               ` Joanne Koong
2026-02-11 15:45     ` Christoph Hellwig
2026-02-12 10:44       ` Pavel Begunkov
2026-02-13  7:18         ` Christoph Hellwig
2026-02-13 12:41           ` Pavel Begunkov
2026-02-13 22:04             ` Joanne Koong
2026-02-18 12:36               ` Pavel Begunkov
2026-02-18 21:43                 ` Joanne Koong
2026-02-20 12:53                   ` Pavel Begunkov
2026-02-21  2:14                     ` Joanne Koong [this message]
2026-02-23 20:00                       ` Pavel Begunkov
2026-02-24 22:19                         ` Joanne Koong
2026-02-27 20:05                           ` Pavel Begunkov
2026-03-02 19:49                             ` Joanne Koong
2026-02-10  0:28 ` [PATCH v1 04/11] io_uring/kbuf: add mmap " Joanne Koong
2026-02-10  1:02   ` Jens Axboe
2026-02-10  0:28 ` [PATCH v1 05/11] io_uring/kbuf: support kernel-managed buffer rings in buffer selection Joanne Koong
2026-02-10  0:28 ` [PATCH v1 06/11] io_uring/kbuf: add buffer ring pinning/unpinning Joanne Koong
2026-02-10  1:07   ` Jens Axboe
2026-02-10 17:57     ` Caleb Sander Mateos
2026-02-10 18:00       ` Jens Axboe
2026-02-10  0:28 ` [PATCH v1 07/11] io_uring/kbuf: add recycling for kernel managed buffer rings Joanne Koong
2026-02-10  0:52   ` Jens Axboe
2026-02-10  0:28 ` [PATCH v1 08/11] io_uring/kbuf: add io_uring_is_kmbuf_ring() Joanne Koong
2026-02-10  0:28 ` [PATCH v1 09/11] io_uring/kbuf: export io_ring_buffer_select() Joanne Koong
2026-02-10  0:28 ` [PATCH v1 10/11] io_uring/kbuf: return buffer id in buffer selection Joanne Koong
2026-02-10  0:53   ` Jens Axboe
2026-02-10 22:36     ` Joanne Koong
2026-02-10  0:28 ` [PATCH v1 11/11] io_uring/cmd: set selected buffer index in __io_uring_cmd_done() Joanne Koong
2026-02-10  0:55 ` [PATCH v1 00/11] io_uring: add kernel-managed buffer rings Jens Axboe
2026-02-10 22:45   ` Joanne Koong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJnrk1Zr=9RMGpNXpe6=fSDkG2uVijB9qa1vENHpQozB3iPQtg@mail.gmail.com' \
    --to=joannelkoong@gmail.com \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=bernd@bsbernd.com \
    --cc=csander@purestorage.com \
    --cc=hch@infradead.org \
    --cc=io-uring@vger.kernel.org \
    --cc=krisman@suse.de \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox