From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB1D3ECAAD3 for ; Wed, 31 Aug 2022 15:56:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231383AbiHaP4z (ORCPT ); Wed, 31 Aug 2022 11:56:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231336AbiHaP4e (ORCPT ); Wed, 31 Aug 2022 11:56:34 -0400 Received: from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com [IPv6:2607:f8b0:4864:20::1134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60359A3447 for ; Wed, 31 Aug 2022 08:56:22 -0700 (PDT) Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-33dc31f25f9so311250237b3.11 for ; Wed, 31 Aug 2022 08:56:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=cCRpuq5ugrZCMPNASqLzmnmQqSHwIbDaqesnsW6hpVY=; b=dp7ag/s/XswteEOQhIlZJ0Nr9OSh2piBWOaxYRC3sJJA1h7P9YiBLyTj5ZbqtTA5s/ QVBATN/coisioHRuuIpGq3gJNfqJZeq14BoEa/ktEy7OjVkakgw2dN07PvsjfH2DKU0B bxLma1WzIl4FKw+quVea/qjMwPtAOmq0TevZHzdNCNncQhM1PD4uyKVu4HWZvLI6BqTx H7kaRy09fBu1xgcDeDqWrzFeKvin7yA3AAOKZ6MQsBsn3T/kb8YICvKVh7LgyXMq+5Bi FLuEciavzkBG7ruhxzyjiDdwLtfbNolH0swGrGj9z+IyuUE/sK6RMxqKOGNWiAhwfBa3 5mXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=cCRpuq5ugrZCMPNASqLzmnmQqSHwIbDaqesnsW6hpVY=; b=KeyYehpSdX5ENZyOXAOjCXOoUQyhsnh6I0tAOdU4G9j/mVq9KiItvPGNufoNdHvf4H c7VUQaND04EwY+F5eLImHroPwCYjFeoRlKnKB5wLzY0j+15IRPU62TeGvMYjk+xfNy44 yyAibBdTj7IxFuE9m2DayR86m0fGTftK242xhcUpOSl7kb23x6oEyAZfeEN5+rm6tQNc 7Y/0hZq+5hvGMGmmFmRb6d2hZIPIZS7iQ6FYiv9P8290e2mvn7T6Pj4VJ3v9wMigeCAJ viYIsvuwbm1/6SR917F/GwIooBllk4V5mKIxChoi1P1KdNyR0wJp6VguPmHBuF2ZhCyz gE8g== X-Gm-Message-State: ACgBeo0y6bqARVb8NVlmf8zSQLcQ0G4GxQJyyBNlaE02dgcFLCnUGqqw nO3dHgV7N5i3ncLSDfU5H+Bz676muuNLiEBYH9DWcg== X-Google-Smtp-Source: AA6agR7Lu6PK9CdXu23xIn3AG3MYNgxqZ4pzHv7Fy3xw9o0fL/gGGSH+N2uXtSf2ZsqL9IuP0dnF/6Y/gY//h7qjU0c= X-Received: by 2002:a81:85c3:0:b0:33d:a4d9:4599 with SMTP id v186-20020a8185c3000000b0033da4d94599mr18562781ywf.237.1661961381492; Wed, 31 Aug 2022 08:56:21 -0700 (PDT) MIME-Version: 1.0 References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-23-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Wed, 31 Aug 2022 08:56:10 -0700 Message-ID: Subject: Re: [RFC PATCH 22/30] Code tagging based fault injection To: Randy Dunlap Cc: Andrew Morton , Kent Overstreet , Michal Hocko , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Mel Gorman , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Peter Zijlstra , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , dvyukov@google.com, Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Tue, Aug 30, 2022 at 6:52 PM Randy Dunlap wrote: > > > > On 8/30/22 14:49, Suren Baghdasaryan wrote: > > From: Kent Overstreet > > > > This adds a new fault injection capability, based on code tagging. > > > > To use, simply insert somewhere in your code > > > > dynamic_fault("fault_class_name") > > > > and check whether it returns true - if so, inject the error. > > For example > > > > if (dynamic_fault("init")) > > return -EINVAL; > > > > There's no need to define faults elsewhere, as with > > include/linux/fault-injection.h. Faults show up in debugfs, under > > /sys/kernel/debug/dynamic_faults, and can be selected based on > > file/module/function/line number/class, and enabled permanently, or in > > oneshot mode, or with a specified frequency. > > > > Signed-off-by: Kent Overstreet > > Missing Signed-off-by: from Suren. > See Documentation/process/submitting-patches.rst: > > When to use Acked-by:, Cc:, and Co-developed-by: > ------------------------------------------------ > > The Signed-off-by: tag indicates that the signer was involved in the > development of the patch, or that he/she was in the patch's delivery path. Thanks for the note! Will fix in the next respin. > > > -- > ~Randy