public inbox for [email protected]
 help / color / mirror / Atom feed
From: Arnd Bergmann <[email protected]>
To: Christoph Hellwig <[email protected]>
Cc: Jens Axboe <[email protected]>,
	Pavel Begunkov <[email protected]>,
	Arnd Bergmann <[email protected]>,
	[email protected],
	Linux Kernel Mailing List <[email protected]>
Subject: Re: [PATCH] [RFC] io_uring: warning about unused-but-set parameter
Date: Mon, 20 Sep 2021 14:48:23 +0200	[thread overview]
Message-ID: <CAK8P3a30a1SKh+71+EgPmsJ1FKJTPKYQuAFUebwKKrhuVzBh3Q@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>

On Mon, Sep 20, 2021 at 2:18 PM Christoph Hellwig <[email protected]> wrote:
>
> On Mon, Sep 20, 2021 at 02:13:44PM +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann <[email protected]>
> >
> > When enabling -Wunused warnings by building with W=1, I get an
> > instance of the -Wunused-but-set-parameter warning in the io_uring code:
> >
> > fs/io_uring.c: In function 'io_queue_async_work':
> > fs/io_uring.c:1445:61: error: parameter 'locked' set but not used [-Werror=unused-but-set-parameter]
> >  1445 | static void io_queue_async_work(struct io_kiocb *req, bool *locked)
> >       |                                                       ~~~~~~^~~~~~
> >
> > There are very few warnings of this type, so it would be nice to enable
> > this by default and fix all the existing instances. I was almost
> > done, but this was added recently as a precaution to prevent code
> > from using the parameter, which could be done by either removing
> > the initialization, or by adding a (fake) use of the variable, which
> > I do here with the cast to void.
>
> Please don't.  These warning are utterly stupid and should not be
> enabled.  For anything that is a "method" of sorts (that is assigned
> to a function pointer), unused argument are perfectly normal.

I'm not suggesting to enable -Wunused-parameter, which would be
complete madness of crouse, only -Wunused-but-set-parameter,
which is already part of W=1 and has the potential of catching
actual bugs such as

int f(int val)
{
      if (val = 1)
            return 0;

       return -1;
}

          Arnd

  reply	other threads:[~2021-09-20 12:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-20 12:13 [PATCH] [RFC] io_uring: warning about unused-but-set parameter Arnd Bergmann
2021-09-20 12:18 ` Christoph Hellwig
2021-09-20 12:48   ` Arnd Bergmann [this message]
2021-09-21  6:54     ` Christoph Hellwig
2021-09-20 23:08 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a30a1SKh+71+EgPmsJ1FKJTPKYQuAFUebwKKrhuVzBh3Q@mail.gmail.com \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox