From: Filipe Manana <[email protected]>
To: Stefan Roesch <[email protected]>
Cc: [email protected], [email protected],
[email protected], [email protected],
[email protected]
Subject: Re: [PATCH v2 10/12] btrfs: make balance_dirty_pages nowait compatible
Date: Thu, 8 Sep 2022 11:16:24 +0100 [thread overview]
Message-ID: <CAL3q7H7Zh0VzPG_F2cM5e37QzpOEkRNaCjPrzicKtm=muidR9A@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
On Thu, Sep 8, 2022 at 1:26 AM Stefan Roesch <[email protected]> wrote:
>
> This replaces the call to function balance_dirty_pages_ratelimited() in
> the function btrfs_buffered_write() with a call to
> balance_dirty_pages_ratelimited_flags().
>
> It also moves the function after the again label. This can cause the
> function to be called a bit later, but this should have no impact in the
> real world.
>
> Signed-off-by: Stefan Roesch <[email protected]>
> ---
> fs/btrfs/file.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c
> index 6e191e353b22..fd42ba9de7a7 100644
> --- a/fs/btrfs/file.c
> +++ b/fs/btrfs/file.c
> @@ -1654,6 +1654,7 @@ static noinline ssize_t btrfs_buffered_write(struct kiocb *iocb,
> loff_t old_isize = i_size_read(inode);
> unsigned int ilock_flags = 0;
> bool nowait = iocb->ki_flags & IOCB_NOWAIT;
> + unsigned int bdp_flags = nowait ? BDP_ASYNC : 0;
>
> if (nowait)
> ilock_flags |= BTRFS_ILOCK_TRY;
> @@ -1756,6 +1757,10 @@ static noinline ssize_t btrfs_buffered_write(struct kiocb *iocb,
>
> release_bytes = reserve_bytes;
> again:
> + ret = balance_dirty_pages_ratelimited_flags(inode->i_mapping, bdp_flags);
> + if (unlikely(ret))
We normally only use likely or unlikely in contextes where we observe
that it makes a significant difference.
What's the motivation here, have you verified that in this case it has
a significant impact?
Thanks.
> + break;
> +
> /*
> * This is going to setup the pages array with the number of
> * pages we want, so we don't really need to worry about the
> @@ -1860,8 +1865,6 @@ static noinline ssize_t btrfs_buffered_write(struct kiocb *iocb,
>
> cond_resched();
>
> - balance_dirty_pages_ratelimited(inode->i_mapping);
> -
> pos += copied;
> num_written += copied;
> }
> --
> 2.30.2
>
next prev parent reply other threads:[~2022-09-08 10:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 0:26 [PATCH v2 00/12] io-uring/btrfs: support async buffered writes Stefan Roesch
2022-09-08 0:26 ` [PATCH v2 01/12] mm: export balance_dirty_pages_ratelimited_flags() Stefan Roesch
2022-09-08 10:18 ` Filipe Manana
2022-09-08 0:26 ` [PATCH v2 02/12] btrfs: implement a nowait option for tree searches Stefan Roesch
2022-09-08 13:19 ` Josef Bacik
2022-09-08 18:05 ` Stefan Roesch
2022-09-08 0:26 ` [PATCH v2 03/12] btrfs: make can_nocow_extent nowait compatible Stefan Roesch
2022-09-08 0:26 ` [PATCH v2 04/12] btrfs: add the ability to use NO_FLUSH for data reservations Stefan Roesch
2022-09-08 0:26 ` [PATCH v2 05/12] btrfs: add btrfs_try_lock_ordered_range Stefan Roesch
2022-09-08 10:18 ` Filipe Manana
2022-09-08 18:12 ` Stefan Roesch
2022-09-08 0:26 ` [PATCH v2 06/12] btrfs: make btrfs_check_nocow_lock nowait compatible Stefan Roesch
2022-09-08 10:18 ` Filipe Manana
2022-09-08 18:23 ` Stefan Roesch
2022-09-08 0:26 ` [PATCH v2 07/12] btrfs: make prepare_pages " Stefan Roesch
2022-09-08 10:17 ` Filipe Manana
2022-09-08 18:33 ` Stefan Roesch
2022-09-08 0:26 ` [PATCH v2 08/12] btrfs: make lock_and_cleanup_extent_if_need " Stefan Roesch
2022-09-08 10:17 ` Filipe Manana
2022-09-08 18:38 ` Stefan Roesch
2022-09-08 0:26 ` [PATCH v2 09/12] btrfs: btrfs: plumb NOWAIT through the write path Stefan Roesch
2022-09-08 10:16 ` Filipe Manana
2022-09-08 18:44 ` Stefan Roesch
2022-09-08 0:26 ` [PATCH v2 10/12] btrfs: make balance_dirty_pages nowait compatible Stefan Roesch
2022-09-08 10:16 ` Filipe Manana [this message]
2022-09-08 18:48 ` Stefan Roesch
2022-09-08 0:26 ` [PATCH v2 11/12] btrfs: add assert to search functions Stefan Roesch
2022-09-08 10:15 ` Filipe Manana
2022-09-08 19:10 ` Stefan Roesch
2022-09-08 0:26 ` [PATCH v2 12/12] btrfs: enable nowait async buffered writes Stefan Roesch
2022-09-08 10:14 ` Filipe Manana
2022-09-08 19:14 ` Stefan Roesch
2022-09-08 10:14 ` [PATCH v2 00/12] io-uring/btrfs: support " Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL3q7H7Zh0VzPG_F2cM5e37QzpOEkRNaCjPrzicKtm=muidR9A@mail.gmail.com' \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox