public inbox for [email protected]
 help / color / mirror / Atom feed
From: Victor Stewart <[email protected]>
To: io-uring <[email protected]>
Subject: [Bug] io_uring_register_files_update broken
Date: Wed, 30 Jun 2021 22:14:51 +0100	[thread overview]
Message-ID: <CAM1kxwgU2V0RsE+77mRUg+mr6WL5PJpbFKh4FrEGOnfzZ5vZ3A@mail.gmail.com> (raw)

i'm fairly confident there is something broken with
io_uring_register_files_update,
especially the offset parameter.

when trying to update a single fd, and getting a successful result of
1, proceeding
operations with IOSQE_FIXED_FILE fail with -9. but if i update all of
the fds with
then my recv operations succeed, but close still fails with -9.

on Clear LInux 5.12.13-1050.native

here's a diff for liburing send_recv test, to demonstrate this.

diff --git a/test/send_recv.c b/test/send_recv.c
index 19adbdd..492b591 100644
--- a/test/send_recv.c
+++ b/test/send_recv.c
@@ -27,6 +27,8 @@ static char str[] = "This is a test of send and recv
over io_uring!";
 #      define io_uring_prep_recv io_uring_prep_read
 #endif

+static int *fds;
+
 static int recv_prep(struct io_uring *ring, struct iovec *iov, int *sock,
                     int registerfiles)
 {
@@ -54,17 +56,28 @@ static int recv_prep(struct io_uring *ring, struct
iovec *iov, int *sock,
                goto err;
        }

+       fds = malloc(100 * sizeof(int));
+       memset(fds, 0xff, sizeof(int) * 100);
+
        if (registerfiles) {
-               ret = io_uring_register_files(ring, &sockfd, 1);
+               ret = io_uring_register_files(ring, fds, 100);
                if (ret) {
                        fprintf(stderr, "file reg failed\n");
                        goto err;
                }
-               use_fd = 0;
-       } else {
-               use_fd = sockfd;
+
+               fds[sockfd] = sockfd;
+               int result = io_uring_register_files_update(ring,
sockfd, fds, 1);
+
+               if (result != 1)
+               {
+                       fprintf(stderr, "file update failed\n");
+                       goto err;
+               }
        }

+       use_fd = sockfd;
+
        sqe = io_uring_get_sqe(ring);
        io_uring_prep_recv(sqe, use_fd, iov->iov_base, iov->iov_len, 0);
        if (registerfiles)

             reply	other threads:[~2021-06-30 21:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-30 21:14 Victor Stewart [this message]
2021-06-30 21:27 ` [Bug] io_uring_register_files_update broken Pavel Begunkov
2021-07-01 14:01   ` Daniele Salvatore Albano
2021-07-01 14:31     ` Pavel Begunkov
2021-07-01 14:50 ` Pavel Begunkov
2021-07-01 15:46   ` Victor Stewart
2021-07-02  0:20     ` Pavel Begunkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM1kxwgU2V0RsE+77mRUg+mr6WL5PJpbFKh4FrEGOnfzZ5vZ3A@mail.gmail.com \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox