From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 647C4C433FE for ; Sat, 12 Dec 2020 18:00:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 30B4322287 for ; Sat, 12 Dec 2020 18:00:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439640AbgLLR7T (ORCPT ); Sat, 12 Dec 2020 12:59:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2439639AbgLLR7T (ORCPT ); Sat, 12 Dec 2020 12:59:19 -0500 Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B32CC0613D6 for ; Sat, 12 Dec 2020 09:58:39 -0800 (PST) Received: by mail-ed1-x542.google.com with SMTP id u19so12851219edx.2 for ; Sat, 12 Dec 2020 09:58:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nametag.social; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=w9wA8pvuLFNHnVRsXy7sHEJrsqyWrHLgJ6VAbhFUT3c=; b=xU27+JEaunbHQlMEYNHOmDt+5f+SxEm9NggJzM7nrPSZq7jU7KgnfPa6hQ1bEIQJKV fYX1vHFOw3VuoP3xCZbfhYB/eG2/ngjBu4+q6mFkPkbwq8+DBha7riNZW+/rH22oxeDc ap2YW3hjDnwcu5aAwvryCE2D77CpW1cp1am7luFUm6GJkttz5fMV9hHQm8pi5FQxIaQl VTu8qZYo33qPxNtVHA22/uh0WXFR5h6ciwbvIlz6W5mLfNWLRHHOYU7YyRXhjC9jh86c vrCNq9F5NVXGiGCajbyk3FCgHY13aYpU2OefNP0FCtX4Nl4VwZL2hqykS8Kgm19TxyiO QCBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w9wA8pvuLFNHnVRsXy7sHEJrsqyWrHLgJ6VAbhFUT3c=; b=DqRd4zdcyocpugTf6+gKUO7EkY0zcSZ/ev5Fle1dv0sI45DvkYGnh1VYlcANF0ssYM 6CUIu7KGoRrYFTaRNi+m4FizcuGit4LU9HNw0SdbYkgQN52Cx6Nq6zywiR2XIORw0FJO OP+hwum9tPi8/82XFNMid8MstSpnKXEnEWR8SkrpLUGBd/SjAldfYbe2Zy6tCyjdOiTX EmSt0JF/u8YAjcVfSWrs/k3rx6VsfIzNr3JvNMk8mVVzozpwAGnmPPY4t3DE7VOnILB1 ZHuSAdht67kIeTH+kPo07Ls6OuJZB/Rk083Sp/3xf66+8ScrDgr1VrsYsvf1+RvpZZv3 iBUA== X-Gm-Message-State: AOAM530ft9ezWFG9lC86+zChQ4eivkEPpKQw4uzC0q+jtpmE0os25XPk 0OUZAJ9PiDoSvzySQNIpbDabsiTf/Rl+3i6uTmUW2Q== X-Google-Smtp-Source: ABdhPJxPU+T6Xu63awD2j/omKu+aMd3x7xXtfH5sHPJILDRGWafpPV9Jmw9uIOGKySNOBsl+AaHHt0DiDhLAoO5klk8= X-Received: by 2002:a05:6402:1ad1:: with SMTP id ba17mr17204660edb.51.1607795917686; Sat, 12 Dec 2020 09:58:37 -0800 (PST) MIME-Version: 1.0 References: <750bc4e7-c2ce-e33d-dc98-483af96ff330@kernel.dk> In-Reply-To: From: Victor Stewart Date: Sat, 12 Dec 2020 17:58:26 +0000 Message-ID: Subject: Re: [PATCH 0/3] PROTO_CMSG_DATA_ONLY for Datagram (UDP) To: Jens Axboe Cc: io-uring , Soheil Hassas Yeganeh , netdev , Stefan Metzmacher , Jann Horn Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Sat, Dec 12, 2020 at 5:40 PM Jens Axboe wrote: > > On 12/12/20 10:25 AM, Victor Stewart wrote: > > On Sat, Dec 12, 2020 at 5:07 PM Jens Axboe wrote: > >> > >> On 12/12/20 8:31 AM, Victor Stewart wrote: > >>> RE our conversation on the "[RFC 0/1] whitelisting UDP GSO and GRO > >>> cmsgs" thread... > >>> > >>> https://lore.kernel.org/io-uring/CAM1kxwi5m6i8hrtkw7nZYoziPTD-Wp03+fcsUwh3CuSc=81kUQ@mail.gmail.com/ > >>> > >>> here are the patches we discussed. > >>> > >>> Victor Stewart (3): > >>> net/socket.c: add PROTO_CMSG_DATA_ONLY to __sys_sendmsg_sock > >>> net/ipv4/af_inet.c: add PROTO_CMSG_DATA_ONLY to inet_dgram_ops > >>> net/ipv6/af_inet6.c: add PROTO_CMSG_DATA_ONLY to inet6_dgram_ops > >>> > >>> net/ipv4/af_inet.c > >>> | 1 + > >>> net/ipv6/af_inet6.c > >>> | 1 + > >>> net/socket.c > >>> | 8 +- > >>> 3 files changed, 7 insertions(+), 3 deletions(-) > >> > >> Changes look fine to me, but a few comments: > >> > >> - I'd order 1/3 as 3/3, that ordering makes more sense as at that point it > >> could actually be used. > > > > right that makes sense. > > > >> > >> - For adding it to af_inet/af_inet6, you should write a better commit message > >> on the reasoning for the change. Right now it just describes what the > >> patch does (which is obvious from the change), not WHY it's done. Really > >> goes for current 1/3 as well, commit messages need to be better in > >> general. > >> > > > > okay thanks Jens. i would have reiterated the intention but assumed it > > were implicit given I linked the initial conversation about enabling > > UDP_SEGMENT (GSO) and UDP_GRO through io_uring. > > > >> I'd also CC Jann Horn on the series, he's the one that found an issue there > >> in the past and also acked the previous change on doing PROTO_CMSG_DATA_ONLY. > > > > I CCed him on this reply. Soheil at the end of the first exchange > > thread said he audited the UDP paths and believed this to be safe. > > > > how/should I resubmit the patch with a proper intention explanation in > > the meta and reorder the patches? my first patch and all lol. > > Just post is as a v2 with the change noted in the cover letter. I'd also > ensure that it threads properly, right now it's just coming through as 4 > separate emails at my end. If you're using git send-email, make sure you > add --thread to the arguments. oh i didn't know about git send-email. i was manually constructing / sending them lol. thanks! > > -- > Jens Axboe >