From: Victor Stewart <[email protected]>
To: Jens Axboe <[email protected]>
Cc: io-uring <[email protected]>,
Soheil Hassas Yeganeh <[email protected]>,
netdev <[email protected]>
Subject: Re: [PATCH net-next v5] udp:allow UDP cmsghdrs through io_uring
Date: Thu, 17 Dec 2020 18:30:30 +0000 [thread overview]
Message-ID: <CAM1kxwiwCsMig+1AJQv0nTDOKjjfBS5eW5rK9xUGmVCWdbQu3A@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
might this still make it into 5.11?
On Thu, Dec 17, 2020 at 3:49 PM Jens Axboe <[email protected]> wrote:
>
> On 12/16/20 3:56 PM, Victor Stewart wrote:
> > This patch adds PROTO_CMSG_DATA_ONLY to inet_dgram_ops and inet6_dgram_ops so that UDP_SEGMENT (GSO) and UDP_GRO can be used through io_uring.
> >
> > GSO and GRO are vital to bring QUIC servers on par with TCP throughputs, and together offer a higher
> > throughput gain than io_uring alone (rate of data transit
> > considering), thus io_uring is presently the lesser performance choice.
> >
> > RE http://vger.kernel.org/lpc_net2018_talks/willemdebruijn-lpc2018-udpgso-paper-DRAFT-1.pdf,
> > GSO is about +~63% and GRO +~82%.
> >
> > this patch closes that loophole.
>
> LGTM
>
> Acked-by: Jens Axboe <[email protected]>
>
> --
> Jens Axboe
>
next prev parent reply other threads:[~2020-12-17 18:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 22:56 [PATCH net-next v5] udp:allow UDP cmsghdrs through io_uring Victor Stewart
2020-12-16 22:57 ` Soheil Hassas Yeganeh
2020-12-17 15:49 ` Jens Axboe
2020-12-17 18:30 ` Victor Stewart [this message]
2020-12-17 18:45 ` Jens Axboe
2021-02-17 23:44 ` Victor Stewart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM1kxwiwCsMig+1AJQv0nTDOKjjfBS5eW5rK9xUGmVCWdbQu3A@mail.gmail.com \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox