From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 473D2C2BBCA for ; Thu, 17 Dec 2020 18:31:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F8A7238EF for ; Thu, 17 Dec 2020 18:31:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730242AbgLQSb2 (ORCPT ); Thu, 17 Dec 2020 13:31:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730128AbgLQSb1 (ORCPT ); Thu, 17 Dec 2020 13:31:27 -0500 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A0FDC061794 for ; Thu, 17 Dec 2020 10:30:42 -0800 (PST) Received: by mail-ej1-x631.google.com with SMTP id lt17so39330458ejb.3 for ; Thu, 17 Dec 2020 10:30:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nametag.social; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lfC4hlaL3cRkORnIhJHCSr0BxESS7DkrkwZH7VfEONE=; b=KW4eoHJUzv8FZwvTPkjCkmNEZNyTPitaUCkJwgZBEN567MZsJ/cPY9UHuiZK+XgGU8 wPRsweKH/13xKfLijHBn77WFwj0hWDYvQMLLXb2f9Ula/ewn/5nyVNXo5HaN1UvJFGK7 197cyQAp5Q+/uVdUr4Yb/jljMJwXf9Vl98H1XVzD2POU6ciZcITF+udLjSUM3OH7tzev KZAr86f+fQk/hRmnBf1yqE3JbZKIC2xwFrSnDi6lUXJQH8mUf+EtwaGgMyoFAKRC09KC sCyPlG9XP0sBVoPEtGnkYmtkydP8GLgvY+87cKq4pxhVZqj5Rfs7WfYRRzT+ezAySK7h MyVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lfC4hlaL3cRkORnIhJHCSr0BxESS7DkrkwZH7VfEONE=; b=IzMpshQPWU1gnGcRewvaNqTq8hUsT5tsZ+pQ5R4bLnFSxmm/mpWtaFU3pcWlvDgVcK /doi4Xba7XmDjbA1Kx2sYu8wgfOS6G4Z1Kjnyct44ADD0oqAzqrkvTBZvb4FTsERSXxO S26Ht6HHS08SMSoIP+/TbHltqs6w6Ix5EBmq01tibSbTaWkC356k/wY5RwKjBbaBeFAA PGJQ1Q0QWrud0ohrAE5FCc6u2wMz/p3w8w8g03afpGOWoUS+wj9CVtgvPbZU8+V/PgWV hEcc/1sdlbcxvMZ+ba//VJtT0ErsmadgcU2TsDldFFq+FIb0jWRwVvfFa+i+OGhreCl1 vv4w== X-Gm-Message-State: AOAM53161kbchFKPlhfsobOLWTdK7tAkqLYDHmzc75mss4tpQYIxeMi1 gNlgEIZNjDuRRHlA8MJEPLmZNIYUMdz8gAMneixITA== X-Google-Smtp-Source: ABdhPJwqUl1NfD35pInUwcGmi5kCnCZ5IhiKuXoyxIPSLM/IG5PsUuq5l7VkYFF5OTIKPbSKiBVauiaH0BaSzIIVULo= X-Received: by 2002:a17:906:7cc6:: with SMTP id h6mr289282ejp.161.1608229841149; Thu, 17 Dec 2020 10:30:41 -0800 (PST) MIME-Version: 1.0 References: <20201216225648.48037-1-v@nametag.social> <5869aae1-400c-94a4-523e-e015f386f986@kernel.dk> In-Reply-To: <5869aae1-400c-94a4-523e-e015f386f986@kernel.dk> From: Victor Stewart Date: Thu, 17 Dec 2020 18:30:30 +0000 Message-ID: Subject: Re: [PATCH net-next v5] udp:allow UDP cmsghdrs through io_uring To: Jens Axboe Cc: io-uring , Soheil Hassas Yeganeh , netdev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org might this still make it into 5.11? On Thu, Dec 17, 2020 at 3:49 PM Jens Axboe wrote: > > On 12/16/20 3:56 PM, Victor Stewart wrote: > > This patch adds PROTO_CMSG_DATA_ONLY to inet_dgram_ops and inet6_dgram_ops so that UDP_SEGMENT (GSO) and UDP_GRO can be used through io_uring. > > > > GSO and GRO are vital to bring QUIC servers on par with TCP throughputs, and together offer a higher > > throughput gain than io_uring alone (rate of data transit > > considering), thus io_uring is presently the lesser performance choice. > > > > RE http://vger.kernel.org/lpc_net2018_talks/willemdebruijn-lpc2018-udpgso-paper-DRAFT-1.pdf, > > GSO is about +~63% and GRO +~82%. > > > > this patch closes that loophole. > > LGTM > > Acked-by: Jens Axboe > > -- > Jens Axboe >