From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBE43C433FE for ; Sat, 12 Dec 2020 17:26:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 876D122AAC for ; Sat, 12 Dec 2020 17:26:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405955AbgLLR0I (ORCPT ); Sat, 12 Dec 2020 12:26:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725973AbgLLR0D (ORCPT ); Sat, 12 Dec 2020 12:26:03 -0500 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB3C9C0613CF for ; Sat, 12 Dec 2020 09:25:22 -0800 (PST) Received: by mail-ej1-x641.google.com with SMTP id f23so16795369ejk.2 for ; Sat, 12 Dec 2020 09:25:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nametag.social; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SAldZ74f52N8LRAOY/OkuOIkIq54RAnc0rfu0esyOak=; b=KtLAYTAumTAAiIVaIXhMvc8ulaUr5px3LY/u/JfMH8L7rsXy2sNKQz1Eura21RPM6w hcvJ+94f6w/sI+jqIjF67pGEZEazW4aBUJpjt2hSpnGrIOd6LqpJZ6G6xUJWT1ZOejcn Ju7wmr4eQhq8+ozOrGMSkAOb1U3v6rXiAzN98WWcRxk1EdfY2og9eTleyFqaAy3RKIb6 1z3kgb3dH//Q700fVVP0qyTTuxtveppMZrPJGTV/53szwg+o67ThhSglCdjwV/ULNiJA 5fZyqCZ0zMVRzDg+CC0AiIf31pNtiaNMQRjLPv2tI/CNEDCBjGzq0ecoi4drfcjA67Ur /PAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SAldZ74f52N8LRAOY/OkuOIkIq54RAnc0rfu0esyOak=; b=JFfqN9p9CLBI80pOwoGL5wq7ukymRBmIA9Do/2x2dBzl2dmAE8TAE/ANRHc1YfPmQU OsO5j01cmY6dpiotJXPVMvt4eDQEovhmJ9C8PD+KvZngY94CD92O5b5IkC94E8eO0PqP jl746NziJen9ekka6zZhEWR/XfcAsLInIycSk6aiVwOrgOlYHS0HFUh4vgSVQecVDrXo PHdXjKFmdQF2zkv7zB/ZvyhgFRGIwMeGywP8QgaAdn86cQmrmcr+R5UXemBdsOkFcRcr eC0M5mpECYqNnSxnVE9V3JWyyq+TZBXMpzqwCIM7Xu6Mn7f5+S9CcGsMfLsMTyIcOfAS vNtQ== X-Gm-Message-State: AOAM5329XNCwJrzV6W6dVRIrJMCJXcK4f5gioxCBYzfeiTtZ/kasWR9g ywVDQyk84LRvP8wdj8FoiyG0mANH2044+osSxIpItA== X-Google-Smtp-Source: ABdhPJyOcbrN+3OO1JVaS0DnmPSza1uvHn4A4HpY6XtcyuBaJei0tsFDd2JKEjmNWKDqPrwzp0CNZPu9eB/0na/pbDY= X-Received: by 2002:a17:906:5912:: with SMTP id h18mr15661572ejq.261.1607793921384; Sat, 12 Dec 2020 09:25:21 -0800 (PST) MIME-Version: 1.0 References: <750bc4e7-c2ce-e33d-dc98-483af96ff330@kernel.dk> In-Reply-To: <750bc4e7-c2ce-e33d-dc98-483af96ff330@kernel.dk> From: Victor Stewart Date: Sat, 12 Dec 2020 17:25:10 +0000 Message-ID: Subject: Re: [PATCH 0/3] PROTO_CMSG_DATA_ONLY for Datagram (UDP) To: Jens Axboe Cc: io-uring , Soheil Hassas Yeganeh , netdev , Stefan Metzmacher , Jann Horn Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Sat, Dec 12, 2020 at 5:07 PM Jens Axboe wrote: > > On 12/12/20 8:31 AM, Victor Stewart wrote: > > RE our conversation on the "[RFC 0/1] whitelisting UDP GSO and GRO > > cmsgs" thread... > > > > https://lore.kernel.org/io-uring/CAM1kxwi5m6i8hrtkw7nZYoziPTD-Wp03+fcsUwh3CuSc=81kUQ@mail.gmail.com/ > > > > here are the patches we discussed. > > > > Victor Stewart (3): > > net/socket.c: add PROTO_CMSG_DATA_ONLY to __sys_sendmsg_sock > > net/ipv4/af_inet.c: add PROTO_CMSG_DATA_ONLY to inet_dgram_ops > > net/ipv6/af_inet6.c: add PROTO_CMSG_DATA_ONLY to inet6_dgram_ops > > > > net/ipv4/af_inet.c > > | 1 + > > net/ipv6/af_inet6.c > > | 1 + > > net/socket.c > > | 8 +- > > 3 files changed, 7 insertions(+), 3 deletions(-) > > Changes look fine to me, but a few comments: > > - I'd order 1/3 as 3/3, that ordering makes more sense as at that point it > could actually be used. right that makes sense. > > - For adding it to af_inet/af_inet6, you should write a better commit message > on the reasoning for the change. Right now it just describes what the > patch does (which is obvious from the change), not WHY it's done. Really > goes for current 1/3 as well, commit messages need to be better in > general. > okay thanks Jens. i would have reiterated the intention but assumed it were implicit given I linked the initial conversation about enabling UDP_SEGMENT (GSO) and UDP_GRO through io_uring. > I'd also CC Jann Horn on the series, he's the one that found an issue there > in the past and also acked the previous change on doing PROTO_CMSG_DATA_ONLY. I CCed him on this reply. Soheil at the end of the first exchange thread said he audited the UDP paths and believed this to be safe. how/should I resubmit the patch with a proper intention explanation in the meta and reorder the patches? my first patch and all lol. > > -- > Jens Axboe >