From: Victor Stewart <[email protected]>
To: io-uring <[email protected]>, Jens Axboe <[email protected]>
Subject: [RFC 1/1] whitelisting UDP GSO and GRO cmsgs
Date: Mon, 23 Nov 2020 15:35:28 +0000 [thread overview]
Message-ID: <CAM1kxwjmGd8=992NjY6TjgsbMoxFS5j2_71bgaYUOUT0vG-19A@mail.gmail.com> (raw)
add __sys_whitelisted_cmsghdrs() and configure __sys_recvmsg_sock and
__sys_sendmsg_sock to use it.
Signed-off by: Victor Stewart <[email protected]>
---
net/socket.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/net/socket.c b/net/socket.c
index 6e6cccc2104f..44e28bb08bbe 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -2416,9 +2416,9 @@ static int ___sys_sendmsg(struct socket *sock,
struct user_msghdr __user *msg,
long __sys_sendmsg_sock(struct socket *sock, struct msghdr *msg,
unsigned int flags)
{
- /* disallow ancillary data requests from this path */
if (msg->msg_control || msg->msg_controllen)
- return -EINVAL;
+ if (!__sys_whitelisted_cmsghdrs(msr))
+ return -EINVAL;
return ____sys_sendmsg(sock, msg, flags, NULL, 0);
}
@@ -2620,6 +2620,15 @@ static int ___sys_recvmsg(struct socket *sock,
struct user_msghdr __user *msg,
return err;
}
+static bool __sys_whitelisted_cmsghdrs(struct msghdr *msg)
+{
+ for (struct cmsghdr *cmsg = CMSG_FIRSTHDR(msg); cmsg != NULL;
cmsg = CMSG_NXTHDR(message, cmsg))
+ if (cmsg->cmsg_level != SOL_UDP || (cmsg->cmsg_type !=
UDP_GRO && cmsg->cmsg_type != UDP_SEGMENT))
+ return false;
+
+ return true;
+}
+
/*
* BSD recvmsg interface
*/
@@ -2630,7 +2639,7 @@ long __sys_recvmsg_sock(struct socket *sock,
struct msghdr *msg,
{
if (msg->msg_control || msg->msg_controllen) {
/* disallow ancillary data reqs unless cmsg is plain data */
- if (!(sock->ops->flags & PROTO_CMSG_DATA_ONLY))
+ if (!( sock->ops->flags & PROTO_CMSG_DATA_ONLY ||
__sys_whitelisted_cmsghdrs(msr) ))
return -EINVAL;
}
next reply other threads:[~2020-11-23 15:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 15:35 Victor Stewart [this message]
2020-11-23 15:40 ` [RFC 1/1] whitelisting UDP GSO and GRO cmsgs Victor Stewart
2020-11-23 20:33 ` Pavel Begunkov
2020-11-23 21:23 ` Victor Stewart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM1kxwjmGd8=992NjY6TjgsbMoxFS5j2_71bgaYUOUT0vG-19A@mail.gmail.com' \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox