public inbox for [email protected]
 help / color / mirror / Atom feed
From: Glauber Costa <[email protected]>
To: Jens Axboe <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: Poll ring behavior broken by f0c5c54945ae92a00cdbb43bdf3abaeab6bd3a23
Date: Thu, 20 Aug 2020 22:24:05 -0400	[thread overview]
Message-ID: <CAMdqtNWVRrej-57v+rXhStPzLBh7kuocPpzJ0R--A3AcG36YAQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>

On Thu, Aug 20, 2020 at 9:57 PM Jens Axboe <[email protected]> wrote:
>
> On 8/20/20 6:46 PM, Glauber Costa wrote:
> > I have just noticed that the commit in $subject broke the behavior I
> > introduced in
> > bf3aeb3dbbd7f41369ebcceb887cc081ffff7b75
> >
> > In this commit, I have explained why and when it does make sense to
> > enter the ring if there are no sqes to submit.
> >
> > I guess one could argue that in that case one could call the system
> > call directly, but it is nice that the application didn't have to
> > worry about that, had to take no conditionals, and could just rely on
> > io_uring_submit as an entry point.
> >
> > Since the author is the first to say in the patch that the patch may
> > not be needed, my opinion is that not only it is not needed but in
> > fact broke applications that relied on previous behavior on the poll
> > ring.
> >
> > Can we please revert?
>
> Yeah let's just revert it for now. Any chance you can turn this into
> a test case for liburing? Would help us not break this in the future.

would be my pleasure.

Biggest issue is that poll mode really only works with ext4 and xfs as
far as I know.
That may mean it won't get as much coverage, but maybe that's not relevant.

>
> --
> Jens Axboe
>

  reply	other threads:[~2020-08-21  2:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-21  0:46 Poll ring behavior broken by f0c5c54945ae92a00cdbb43bdf3abaeab6bd3a23 Glauber Costa
2020-08-21  1:57 ` Jens Axboe
2020-08-21  2:24   ` Glauber Costa [this message]
2020-08-21  3:42     ` Jens Axboe
2020-08-21 13:55       ` Glauber Costa
2020-08-21 14:36         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMdqtNWVRrej-57v+rXhStPzLBh7kuocPpzJ0R--A3AcG36YAQ@mail.gmail.com \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox