From: Glauber Costa <[email protected]>
To: [email protected], [email protected],
[email protected]
Subject: Poll ring behavior broken by f0c5c54945ae92a00cdbb43bdf3abaeab6bd3a23
Date: Thu, 20 Aug 2020 20:46:18 -0400 [thread overview]
Message-ID: <CAMdqtNXQbQazseOuyNC_p53QjstsVqUz_6BU2MkAWMMrxEuJ=A@mail.gmail.com> (raw)
I have just noticed that the commit in $subject broke the behavior I
introduced in
bf3aeb3dbbd7f41369ebcceb887cc081ffff7b75
In this commit, I have explained why and when it does make sense to
enter the ring if there are no sqes to submit.
I guess one could argue that in that case one could call the system
call directly, but it is nice that the application didn't have to
worry about that, had to take no conditionals, and could just rely on
io_uring_submit as an entry point.
Since the author is the first to say in the patch that the patch may
not be needed, my opinion is that not only it is not needed but in
fact broke applications that relied on previous behavior on the poll
ring.
Can we please revert?
next reply other threads:[~2020-08-21 0:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 0:46 Glauber Costa [this message]
2020-08-21 1:57 ` Poll ring behavior broken by f0c5c54945ae92a00cdbb43bdf3abaeab6bd3a23 Jens Axboe
2020-08-21 2:24 ` Glauber Costa
2020-08-21 3:42 ` Jens Axboe
2020-08-21 13:55 ` Glauber Costa
2020-08-21 14:36 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMdqtNXQbQazseOuyNC_p53QjstsVqUz_6BU2MkAWMMrxEuJ=A@mail.gmail.com' \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox