From: Eric Dumazet <[email protected]>
To: David Lamparter <[email protected]>
Cc: [email protected], [email protected],
Jens Axboe <[email protected]>
Subject: Re: [PATCH] io_uring: remove MSG_NOSIGNAL from recvmsg
Date: Fri, 24 Feb 2023 17:14:45 +0100 [thread overview]
Message-ID: <CANn89iL1q6vs5MVt9SUNJ6uzPwg738vKKOFvyXQD3K3m7BAd8g@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
On Fri, Feb 24, 2023 at 4:04 PM David Lamparter <[email protected]> wrote:
>
> MSG_NOSIGNAL is not applicable for the receiving side, SIGPIPE is
> generated when trying to write to a "broken pipe". AF_PACKET's
> packet_recvmsg() does enforce this, giving back EINVAL when MSG_NOSIGNAL
> is set - making it unuseable in io_uring's recvmsg.
>
> Remove MSG_NOSIGNAL from io_recvmsg_prep().
>
> Signed-off-by: David Lamparter <[email protected]>
> Cc: Eric Dumazet <[email protected]>
> Cc: Jens Axboe <[email protected]>
> ---
>
> > Sure, or perhaps David wanted to take care of this.
>
> Here you go. But maybe give me a few hours to test/confirm...
>
Reviewed-by: Eric Dumazet <[email protected]>
Thanks !
next prev parent reply other threads:[~2023-02-24 16:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CANn89iJE6SpB2bfXEc=73km6B2xtBSWHj==WsYFnH089WPKtSA@mail.gmail.com>
2023-02-24 15:01 ` [PATCH] io_uring: remove MSG_NOSIGNAL from recvmsg David Lamparter
2023-02-24 15:42 ` David Lamparter
2023-02-24 16:14 ` Eric Dumazet [this message]
2023-02-24 16:57 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANn89iL1q6vs5MVt9SUNJ6uzPwg738vKKOFvyXQD3K3m7BAd8g@mail.gmail.com \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox