From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FD45C7EE23 for ; Fri, 24 Feb 2023 16:15:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229733AbjBXQPB (ORCPT ); Fri, 24 Feb 2023 11:15:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229715AbjBXQPA (ORCPT ); Fri, 24 Feb 2023 11:15:00 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48E96211FD for ; Fri, 24 Feb 2023 08:14:59 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id p8so14588323wrt.12 for ; Fri, 24 Feb 2023 08:14:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wqctOt0Z9Z4oI79oBbfnBf5nVakOpUKrrJaXQvs3lDA=; b=eMn43wEeRu6kCrDb8soTKv4oBUddYu2GcC/dmfld+GvMJeR/DByh+FI0jgjFEU9XMC trxHOZJ+z3CX1Ys7kFb+M7ZHtbJVmpBxKJ0u0PZj5kzJzQOGh4DcOzezEAgGazLd/zte j+JXLR6KJ8EEubKU0clja+9LWSGRXdGosCRM1bY7xtRPnZNpnkGhP/mjDlQIDR/m3KDz oPhYuPTRoeITEpzHyFMMdkZrud8Z7rSAG7Ymsp6qonm4CKkr7DKufYdqFm2R/l3zWq5R tVeBb0U6Dn+b13kxn7lJsdTn8yw9cmdjMgRQjzsHp59OyusIXXsbAoBLo1ToOu3nBoCP w1yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wqctOt0Z9Z4oI79oBbfnBf5nVakOpUKrrJaXQvs3lDA=; b=ZdkXNnm46stWtoyRLlsr4yBjUbj7/+SF4ONj5wNDOGGbgSxT/gVP+QIGxVGcQpzMWV TIC7AQBLwgHMf1juBvGFwkIXAaTyzS++tR2YlidyhLLAvNUxdljTrteJexMdCuLtp3C+ c0PAkqYtPKD17q/aXA3TOcYDmRxkNe/bGlpBqITll4yMXelp7/wMLo1sztU1kqS9DUkv i6VwG6mrAahdvlpRicSXddgeBgFK487a2PdCSp2xuQiuQhPv6MEMimheoCoteUHa3lFH q8jMvzfHapMLfPtN4K4bd8t3cpDhBr24eiTFkHspGF3R+VhpM9gLRfp5KIiUh0AbTUYv Q0UA== X-Gm-Message-State: AO0yUKVtBe8xSNX7N/Ovc5xP6fiRk5A0BiCaYh2EixYaDZZpOwjb+mBE jzENLelIpzMApet2oj2dNTrW2Vw4u/mreuK0vtBiQHmKG57t5LBE X-Google-Smtp-Source: AK7set9tn8+uVIVmP/VkpI+R+yeCwNyOdPrjXWzx2RWUr3qkYE62TTdIkuPoaSVWdp34H5M7jW4uJ0GdeA3U7TaqghM= X-Received: by 2002:a5d:49cd:0:b0:2c3:be6a:d7d4 with SMTP id t13-20020a5d49cd000000b002c3be6ad7d4mr1070400wrs.11.1677255297637; Fri, 24 Feb 2023 08:14:57 -0800 (PST) MIME-Version: 1.0 References: <20230224150123.128346-1-equinox@diac24.net> In-Reply-To: <20230224150123.128346-1-equinox@diac24.net> From: Eric Dumazet Date: Fri, 24 Feb 2023 17:14:45 +0100 Message-ID: Subject: Re: [PATCH] io_uring: remove MSG_NOSIGNAL from recvmsg To: David Lamparter Cc: io-uring@vger.kernel.org, netdev@vger.kernel.org, Jens Axboe Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Fri, Feb 24, 2023 at 4:04=E2=80=AFPM David Lamparter wrote: > > MSG_NOSIGNAL is not applicable for the receiving side, SIGPIPE is > generated when trying to write to a "broken pipe". AF_PACKET's > packet_recvmsg() does enforce this, giving back EINVAL when MSG_NOSIGNAL > is set - making it unuseable in io_uring's recvmsg. > > Remove MSG_NOSIGNAL from io_recvmsg_prep(). > > Signed-off-by: David Lamparter > Cc: Eric Dumazet > Cc: Jens Axboe > --- > > > Sure, or perhaps David wanted to take care of this. > > Here you go. But maybe give me a few hours to test/confirm... > Reviewed-by: Eric Dumazet Thanks !