From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f46.google.com (mail-yx1-f46.google.com [74.125.224.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6103638F629 for ; Fri, 13 Mar 2026 14:02:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=74.125.224.46 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773410569; cv=pass; b=L2ylQGmPcBFjHrXBenx1UGb8Sadv7azeNUt8Z44cwttkMWpuzC8gMBBKT7cE4AYKk6P5MNMuq8RXUE20y+8bZRH9mJ9yyZAJH6aJvuKX/i/Y4E+fIfnwNHcBeEBVzoa0XNUJFFvtwt7UhxnkyJJYvV7S7A7bF5ALCV7V+xzRYNg= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773410569; c=relaxed/simple; bh=a7/dI9iHAkAoxpT/Y/jlrZ1Uk/u+tnKK+1+hPiLUJTk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=cvu0iloogBvGKQK5ukK33oetUATI0GOKtjABcLj1hEo1iQbWPIVW7AV8Si1x7kKgnilVOnee13wCPxjhr7VlUcdERgYDRta+wivVN71RLNxaFmn9oPv5HyjpFImGBV2GfDVtRTC2tfO6ajMXipnnK/IOjigYkc/yyBy+1TWPyfA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bitbyteword.org; spf=pass smtp.mailfrom=bitbyteword.org; dkim=pass (2048-bit key) header.d=bitbyteword.org header.i=@bitbyteword.org header.b=ObfNwz7s; arc=pass smtp.client-ip=74.125.224.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bitbyteword.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bitbyteword.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bitbyteword.org header.i=@bitbyteword.org header.b="ObfNwz7s" Received: by mail-yx1-f46.google.com with SMTP id 956f58d0204a3-64c9ebd1369so2225767d50.1 for ; Fri, 13 Mar 2026 07:02:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1773410565; cv=none; d=google.com; s=arc-20240605; b=BLYZ0WqNOO61vxAj1Lx0MZ+qZl1DCfw5MfTpcAlOMoSe2TPSWZ/b9rth5xJXybh2Gq 6HygCxJJg68uMaNmfEZ04KVn/1knpkiysTYiizr56a/3Z2w2VxfeohKdnq157MhXeMqF DCIVDbZk2xafRozCCGrly0fttfjQ4lUJOnlAG4Ex4y0UT/lD/RQbPJBEw24nmTUzOqax XcDYn9fRCDBUiC8RArvdb4/0Q2XTqYRSmOz26r6bQeyA2Kr77cwfPBTzqFDQgREkj3O6 +1H3vUFHWaEizFLWft61iTviZmgEECLdi2Ow1KoRvjZR+9kO9P91LN9TbR0YKeJssdqy xAVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=a7/dI9iHAkAoxpT/Y/jlrZ1Uk/u+tnKK+1+hPiLUJTk=; fh=KJsGTxMHXmzUyMm9hNDPiko2N4RuSCgp369MHs94iTM=; b=aq17VN/pJB2KtBXhOoqoPjbIkrnv+NN9NYOlH7hUwOnaSQkrPvf2yMyVf9CeHQHj3D rlbm+TN9UHeloujgeoXx6onZN0feE97M4cq/wdRLU3lIbacpRUKc7SM9wtGMPG+OAib3 Kfnu3ZQ42q4hzS3KmUsTjYCicr1XcBzonOE21EWbPFV28q8awbluhfFRnty7u+Q2kwF2 0h8bv6ZAto7lrF5KpIqTTlqanbIicNmjNxg1M9RgRnVyflte/QeSxAdZqwjjxjLpZx64 16qTUE0yh7X23sK9l6zByByTHhBMpFdXGasHHTiCso6JolnokQ3r14j9dAlVFzFMi71c 9Fpw==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bitbyteword.org; s=google; t=1773410565; x=1774015365; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=a7/dI9iHAkAoxpT/Y/jlrZ1Uk/u+tnKK+1+hPiLUJTk=; b=ObfNwz7sVmzZBuIGYYUHNiLCrYOnrj8c6jSXCTXbQttafWQ6iigv2iFCUWBaoiYoUP 65QJafHt+sCKkuHWwkmPoCcyygdqmYnJqwQvkPOoFp//2xTrPOAnMOEt6QHOb6B2JvqT uUidn8yG11+xxULj+cUGv2RAFi7xkRZfAAMzfTE8wLSqLl+bB0W1/CQna7kgFTcQ079U jdJDbGknVFFIGRjt+9Ia/rAPUbdCEaVBzQY/lQOSzveUUMV9JbrJZ9dM14sssdL0Veoz 2HvOhbyl3fwXxpTdX3XOVWdJQawUfi41VBhM025fBbFm4jHJUnRUxEJqrBTBuYU1u6Rq p7og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773410565; x=1774015365; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=a7/dI9iHAkAoxpT/Y/jlrZ1Uk/u+tnKK+1+hPiLUJTk=; b=Q6h6jeo3XGqlMPKAxCidE/BJR8ijy6hiZqWMOwDUaKdvnJtsHfQktEpM0l40mtcQl4 k77qXRtSimY6DhjuqXdxQFUrPb/Iry+Fqjq7NujwBkBCdjZEbTfwsqIm6utWpEhtm0IJ EH5TUqrhwL5yqgEMjnauN1wjRjFd5UEj5YuSny2q46BpgA952NuIMfVo5jqCPnbmrjQm HLhj45/wExyDTYVAOlR4ufRaLsSdpkmUVHvDvvgAxiasHgLzEvYNwEGY7in33eg77jhM rhdLu7KNDwURCX0Jkc8IiTGB108BvVO2RJ+Iwrc16LBALdJR6s6IRcgCTNxcdqYwNGjb vq7g== X-Forwarded-Encrypted: i=1; AJvYcCUy8UUPMCV+QSXKVDHo+OkOmDiCVmZNEC+tcMAEJuUWUtbttaJhf6OzXrfe5v8yc577jKJE8e1NgA==@vger.kernel.org X-Gm-Message-State: AOJu0YwICMpvE0jZZbNZ+Oilvka7tWL2K9D9uVlhieaUNPF7hU/gqe50 0TxtCHB0gWC3FRFTJpETBdvLJFXCMb7hSrYrhxoX4nolux5+C7TH83CvS6nyTX6qVjzZepgKlI1 Wv8y3Ewd2/XG6JArdFLcVIOhhTOVqeMBeRZkcfNo+og== X-Gm-Gg: ATEYQzzMHuYJYXofGQAnVQNVVsrQI0l34JK81v/GHWYjvRBqikiK4T1DuKgOafCle7C ipG/akK5ZCEYmR2Xdce9Z8MU8lv4dNnP5HQUxttfTMsucraztgN8j4x6VJoIUfxNoAW8cMuhnv3 gmIO/Rj5cnWKVV/UaC4heI4CDI/nrzoIrIMsWKY90XK5+EReimXjXEZoLyPw9tG2nUnAGQvlsnw zkvpXUQ3I7iUVr3oJrmdy1Iv3g932fWxB0ICFTbrHooqv7IjDm2/rTs/sNXRcrUnCWw/aQbim4y gdDzVh0= X-Received: by 2002:a53:eccf:0:b0:64d:568b:bcb3 with SMTP id 956f58d0204a3-64e62eeb40fmr2691449d50.9.1773410564388; Fri, 13 Mar 2026 07:02:44 -0700 (PDT) Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260312150523.2054552-1-vineeth@bitbyteword.org> <1e3c2830-765e-4271-89f7-0b6784b37597@efficios.com> <20260312112354.3dd99e36@gandalf.local.home> <219d015d-076b-4c80-8f63-88569115fdad@efficios.com> <20260312114041.5193c729@gandalf.local.home> <1becdbce-2c01-468a-bbab-42b5dea9fdf8@efficios.com> <20260312130255.6476e560@gandalf.local.home> In-Reply-To: <20260312130255.6476e560@gandalf.local.home> From: Vineeth Remanan Pillai Date: Fri, 13 Mar 2026 10:02:32 -0400 X-Gm-Features: AaiRm51K5Hc3O7_rOVK2jMiMzft9bvuP5pyZ-VF_j7db91GKvyylhuGDp34sRoA Message-ID: Subject: Re: [PATCH 00/15] tracepoint: Avoid double static_branch evaluation at guarded call sites To: Steven Rostedt Cc: Andrii Nakryiko , Mathieu Desnoyers , Peter Zijlstra , Dmitry Ilvokhin , Masami Hiramatsu , Ingo Molnar , Jens Axboe , io-uring@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Marcelo Ricardo Leitner , Xin Long , Jon Maloy , Aaron Conole , Eelco Chaudron , Ilya Maximets , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-sctp@vger.kernel.org, tipc-discussion@lists.sourceforge.net, dev@openvswitch.org, Oded Gabbay , Koby Elbaz , dri-devel@lists.freedesktop.org, "Rafael J. Wysocki" , Viresh Kumar , "Gautham R. Shenoy" , Huang Rui , Mario Limonciello , Len Brown , Srinivas Pandruvada , linux-pm@vger.kernel.org, MyungJoo Ham , Kyungmin Park , Chanwoo Choi , =?UTF-8?Q?Christian_K=C3=B6nig?= , Sumit Semwal , linaro-mm-sig@lists.linaro.org, Eddie James , Andrew Jeffery , Joel Stanley , linux-fsi@lists.ozlabs.org, David Airlie , Simona Vetter , Alex Deucher , Danilo Krummrich , Matthew Brost , Philipp Stanner , Harry Wentland , Leo Li , amd-gfx@lists.freedesktop.org, Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org, Wolfram Sang , linux-i2c@vger.kernel.org, Mark Brown , Michael Hennerich , =?UTF-8?B?TnVubyBTw6E=?= , linux-spi@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, Chris Mason , David Sterba , linux-btrfs@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 12, 2026 at 1:03=E2=80=AFPM Steven Rostedt wrote: > > On Thu, 12 Mar 2026 09:54:29 -0700 > Andrii Nakryiko wrote: > > > > > emit_trace_foo() > > > > __trace_foo() > > > > this seems like the best approach, IMO. double-underscored variants > > are usually used for some specialized/internal version of a function > > when we know that some conditions are correct (e.g., lock is already > > taken, or something like that). Which fits here: trace_xxx() will > > check if tracepoint is enabled, while __trace_xxx() will not check and > > just invoke the tracepoint? It's short, it's distinct, and it says "I > > know what I am doing". > > Honestly, I consider double underscore as internal only and not something > anyone but the subsystem maintainers use. > > This, is a normal function where it's just saying: If you have it already > enabled, then you can use this. Thus, I don't think it qualifies as a "yo= u > know what you are doing". > > Perhaps: call_trace_foo() ? > call_trace_foo has one collision with the tracepoint sched_update_nr_running and a function call_trace_sched_update_nr_running. I had considered this and later moved to trace_invoke_foo() because of the collision. But I can rename call_trace_sched_update_nr_running to something else if call_trace_foo is the general consensus. Thanks, Vineeth