From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f47.google.com (mail-yx1-f47.google.com [74.125.224.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75BB63F65F4 for ; Thu, 12 Mar 2026 16:09:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=74.125.224.47 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773331744; cv=pass; b=evVgLyMzzlO42I/Zk5uGnN9Jmv6YRKLhdc2+KfCGzRgmmB5KBMC9echtt4sOBc1fOvrNqn6PihSrxHuF8YgTg6fIrblpT05bNt8vSsA1M1hi7ESKVfwjHxSLpiFJ4jEcDoD79F7Eans7d/mtnrnBsi+JhPOdy0baDdsLm6+B0gc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773331744; c=relaxed/simple; bh=/9ZhlXnE8IpHyY7rKGq8AMXoEoLmeVmAM+IAe1Oezhg=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=rwVM9tV12CvDAX3YFseBfOV5085cJJjZh7PkY7UydIqkCdhODDtA0Gh4guCKa4LBfl5o0NSzhzliMD4MhE9gx3+JgMHxNOR93NFc+BUfV+aAtYDb7F4HIa/WbqDmyFXpVANyF84+oskUy2qr4bD2LDp5bBV6aYcZ1Uh6nLBy9lc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bitbyteword.org; spf=pass smtp.mailfrom=bitbyteword.org; dkim=pass (2048-bit key) header.d=bitbyteword.org header.i=@bitbyteword.org header.b=m1ki3q6s; arc=pass smtp.client-ip=74.125.224.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bitbyteword.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bitbyteword.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bitbyteword.org header.i=@bitbyteword.org header.b="m1ki3q6s" Received: by mail-yx1-f47.google.com with SMTP id 956f58d0204a3-64aedd812baso1195691d50.3 for ; Thu, 12 Mar 2026 09:09:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1773331741; cv=none; d=google.com; s=arc-20240605; b=KV7KetxeEWb4KxiZXK1eoit90wSKaKogPPH8rC8CKPmsRmc61T2JiTdViVNRvMOxOU Q2xw103OJBUiCVYScK9EwRtWqQwclaYl2CH4VOqJAdBjyiMH6sdRKR8l6e6sIyAAA4IU NgAz2F2rufYeEe0mYo9CL0j1pHWkgySWUjU/saOOuw/IYXF3wEKNu7kxumr6MvG/1Cxn VIb7FhI4EMmUZtfO5UerrCOvzDuVGH8JNMpHJkk+ON1XajXkFLnfYX46JV4FeUBWUgyQ 70kEpexF+k7VZq9IMM8nfi2M624BX9oE4xB80+aRuOiNzTEujJIpqKjJZEuji1ciJ57f l6zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=kI5PTFr09piXXwe+dHgxbmefu5uh1N96l8rxcGpDT20=; fh=DgFQJHD7v5F8zsH1a6V0mB24mv2KEMoyuGGoaJMgzXg=; b=GyGuvY5btQqId9d1Ed1RSuNSllhu34y8+YwJcUvVKufAUoMENy6E37gEMsHrScHoR/ JAf4ZsRLwcUCPjDat7HknunsglHGe/CeUqrT4cx+ZyHN9mGu36syvGJgba8lIZtDMToS 87a22X39x++6rSjh+WC5Mb2AjudNApG9DVssIdmd7CVvGgWyxc7/8Qo4dr1Ko4YJWXtO VFYmWGXP86bjUCVz4A1fjrZYlCiVDKpxe3oD27SXJEvjsDqjkDvYFePj5neLZbvd2ibM Y+qYiR9SAIMkgupAvjR30us/hIcXk691wTAJCplOLAHfqecZjRiZzbUijjbcHzJa4D4X cX2g==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bitbyteword.org; s=google; t=1773331741; x=1773936541; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kI5PTFr09piXXwe+dHgxbmefu5uh1N96l8rxcGpDT20=; b=m1ki3q6sM4E2UACesTTqdadtI+Q0abqlUwfIdHI+OjmsRX2whEFMpQZptypVWhQx7h QD04yZlyfzP3xSivF9scjOrX5/FKYwiLrKA2X7JGefZSd1ksKzyMr15sFt8BUlBtCA1S qJU7H/z8w1uO+F9Lf0dqC/P0kEVsXjabxHZfvBx9uTBgICn+qEBxH7rHMoE2jVFa285u ZgHMmgqvOB2dgKagDrzwCVgXrpWT6UXW/+5qlE/3A3PliRynwsbURLgRm9zWpjrvx8vj l50ZunSLyn6Bt2c18cyLVOhmld8Lw2f3Z/Tl83A9P3MTDzd0bDNTqIw9vU+Apak8seEn KC5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773331741; x=1773936541; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kI5PTFr09piXXwe+dHgxbmefu5uh1N96l8rxcGpDT20=; b=I8CGIDPphAe74IdYW+5sRRpATr87e9j7zUrYGEqY7fVdZ1KOD9i8b95uUSa0Gygtyi qMB1afBz5unc/TjlVY1U/R0AtkpJ/NQ/+XZyYRQZToQlx0rLi4gMH7zIsqtQztfq3r9X BbJXJEH+x4HZXldu1pD1zQnk4m1F1t+TlF2Y63gHUsyMoROWbg+6T2OslA+pe5QmrfOn J4+ayRQTUT1arPyv5y88b/MWop9pBBL6ue/mAPK9z8Z65AeF+zYLQ8h1ImYwS7yHD4j+ Zpl/xp27WHV6jjzyIrPabfo4goOqUcYKP5rFWy2KFWt4cMxGO5FnFVcu0Bo+78XfW5iX iH7A== X-Forwarded-Encrypted: i=1; AJvYcCXIjxPOcQ3CRTj3qoJkKHwVLLZZMY/tC0H64920i69fx3sB9p6rqDQFos+eRD++r1pC80X8JnIViA==@vger.kernel.org X-Gm-Message-State: AOJu0YxJzf3qwJuIueT1AuOGy4LZhy19nm4brL7oG07L/QX/AcGjRnDQ 2GS7TapZ7ghQcxb2UvIJoOOiVp3CTb6FWwNy0JPg9xVijuz8c1a0SXDZf1EYv6sJpO3UT3C2T65 XAXh02bHqoC8yG2yolxpYhcWHKHmqssugKD8ERrp6iA== X-Gm-Gg: ATEYQzwQ8RePTY8RsH9sY07Mh6yODEl6713In7toYytbaNe2IG54cG3jk5416wQ3wg2 9v8hEk90ed6bjWNoedevpHAXTnSeDjkH2S7CkLXszWe0LJRU03SeKiIrxctjuWF6WENj6thv2Mg L1atzpy8AvzNLUTWkjtR8/qs7cQMZM1ZyXViuLBsYskRWG4q1P1lq4sW6o5IOBnTNqANGpTudFf qtubWn8NXnjHis+tUvCNbkGifGdVyAU5KmBFCaTlQxtioJkC1IfpUV5VFqjegeRjjuSSems/DHr nqGsUJA= X-Received: by 2002:a05:690e:448d:b0:64a:e799:1d9c with SMTP id 956f58d0204a3-64e63079bb0mr62693d50.60.1773331741406; Thu, 12 Mar 2026 09:09:01 -0700 (PDT) Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260312150523.2054552-1-vineeth@bitbyteword.org> <1e3c2830-765e-4271-89f7-0b6784b37597@efficios.com> <20260312112354.3dd99e36@gandalf.local.home> <219d015d-076b-4c80-8f63-88569115fdad@efficios.com> <20260312114041.5193c729@gandalf.local.home> <1becdbce-2c01-468a-bbab-42b5dea9fdf8@efficios.com> In-Reply-To: <1becdbce-2c01-468a-bbab-42b5dea9fdf8@efficios.com> From: Vineeth Remanan Pillai Date: Thu, 12 Mar 2026 12:08:49 -0400 X-Gm-Features: AaiRm50l09G2avZYKQas6kLTqrDst8ZjnHTnngudy3h6MyVa79lzABXaRh3Trz0 Message-ID: Subject: Re: [PATCH 00/15] tracepoint: Avoid double static_branch evaluation at guarded call sites To: Mathieu Desnoyers Cc: Steven Rostedt , Peter Zijlstra , Dmitry Ilvokhin , Masami Hiramatsu , Ingo Molnar , Jens Axboe , io-uring@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Marcelo Ricardo Leitner , Xin Long , Jon Maloy , Aaron Conole , Eelco Chaudron , Ilya Maximets , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-sctp@vger.kernel.org, tipc-discussion@lists.sourceforge.net, dev@openvswitch.org, Oded Gabbay , Koby Elbaz , dri-devel@lists.freedesktop.org, "Rafael J. Wysocki" , Viresh Kumar , "Gautham R. Shenoy" , Huang Rui , Mario Limonciello , Len Brown , Srinivas Pandruvada , linux-pm@vger.kernel.org, MyungJoo Ham , Kyungmin Park , Chanwoo Choi , =?UTF-8?Q?Christian_K=C3=B6nig?= , Sumit Semwal , linaro-mm-sig@lists.linaro.org, Eddie James , Andrew Jeffery , Joel Stanley , linux-fsi@lists.ozlabs.org, David Airlie , Simona Vetter , Alex Deucher , Danilo Krummrich , Matthew Brost , Philipp Stanner , Harry Wentland , Leo Li , amd-gfx@lists.freedesktop.org, Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org, Wolfram Sang , linux-i2c@vger.kernel.org, Mark Brown , Michael Hennerich , =?UTF-8?B?TnVubyBTw6E=?= , linux-spi@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, Chris Mason , David Sterba , linux-btrfs@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 12, 2026 at 11:49=E2=80=AFAM Mathieu Desnoyers wrote: > > On 2026-03-12 11:40, Steven Rostedt wrote: > > On Thu, 12 Mar 2026 11:28:07 -0400 > > Mathieu Desnoyers wrote: > > > >>> Note, Vineeth came up with the naming. I would have done "do" but whe= n I > >>> saw "invoke" I thought it sounded better. > >> > >> It works as long as you don't have a tracing subsystem called > >> "invoke", then you get into identifier clash territory. > > > > True. Perhaps we should do the double underscore trick. > > > > Instead of: trace_invoke_foo() > > > > use: trace_invoke__foo() > > > > > > Which will make it more visible to what the trace event is. > > > > Hmm, we probably should have used: trace__foo() for all tracepoints, as > > there's still functions that are called trace_foo() that are not > > tracepoints :-p > > One certain way to eliminate identifier clash would be to go for a > prefix to "trace_", e.g. > > do_trace_foo() > call_trace_foo() This was the initial idea, but it had conflict in the existing source: call_trace_sched_update_nr_running. do_trace_##name also had collisions when I checked. So, went with trace_invoke_##name. Did not check rest of the suggestions here though. Thanks, Vineeth > emit_trace_foo() > __trace_foo() > invoke_trace_foo() > dispatch_trace_foo() > > Thanks, > > Mathieu > > > > -- > Mathieu Desnoyers > EfficiOS Inc. > https://www.efficios.com