public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Jens Axboe <axboe@kernel.dk>,
	io-uring Mailing List <io-uring@vger.kernel.org>,
	 "GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	 Christian Mazakas <christian.mazakas@gmail.com>
Subject: Re: [PATCH liburing] liburing.h: Only use `IOURINGINLINE` macro for FFI functions
Date: Tue, 1 Jul 2025 03:41:19 +0700	[thread overview]
Message-ID: <CAOG64qM-zfnBTX1xaGvab7+0i=07G-pasWbS8vkis1M4A1uxLw@mail.gmail.com> (raw)
In-Reply-To: <20250630203641.1217131-1-ammarfaizi2@gnuweeb.org>

On Tue, Jul 1, 2025 at 3:36 AM Ammar Faizi wrote:
> These 3 inline functions are for liburing internal use, it does not
> make much sense to export them:
>
>   uring_ptr_to_u64
>   io_uring_cqe_iter_init
>   io_uring_cqe_iter_next
>
> Don't use IOURINGINLINE on them. Also, add a comment on the
> IOURINGINLINE macro definition explaining when to use IOURINGINLINE
> and remind the reader to add the exported function to liburing-ffi.map
> if they introduce a function marked with IOURINGINLINE.
>
> Cc: Christian Mazakas <christian.mazakas@gmail.com>
> Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
> Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>

Reviewed-by: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>

  reply	other threads:[~2025-06-30 20:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-30 20:36 [PATCH liburing] liburing.h: Only use `IOURINGINLINE` macro for FFI functions Ammar Faizi
2025-06-30 20:41 ` Alviro Iskandar Setiawan [this message]
2025-06-30 21:39 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOG64qM-zfnBTX1xaGvab7+0i=07G-pasWbS8vkis1M4A1uxLw@mail.gmail.com' \
    --to=alviro.iskandar@gnuweeb.org \
    --cc=ammarfaizi2@gnuweeb.org \
    --cc=axboe@kernel.dk \
    --cc=christian.mazakas@gmail.com \
    --cc=gwml@vger.gnuweeb.org \
    --cc=io-uring@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox