From: Alviro Iskandar Setiawan <[email protected]>
To: Ammar Faizi <[email protected]>
Cc: Jens Axboe <[email protected]>, Nugra <[email protected]>,
"GNU/Weeb Mailing List" <[email protected]>,
Tea Inside Mailing List <[email protected]>,
io-uring Mailing List <[email protected]>
Subject: Re: [PATCH liburing v1] src/Makefile: Don't use stack protector for all builds by default
Date: Fri, 25 Feb 2022 05:33:56 +0700 [thread overview]
Message-ID: <CAOG64qOgZ9bvdCV3-N=uk4ZCCj46W1VJU_+kN9ZsV8uTMnJ8-A@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
On Fri, Feb 25, 2022 at 5:25 AM Ammar Faizi <[email protected]> wrote:
> Stack protector adds extra mov, extra stack allocation and extra branch
> to save and validate the stack canary. While this feature could be
> useful to detect stack corruption in some scenarios, it is not really
> needed for liburing which is simple enough to review.
>
> Good code shouldn't corrupt the stack. We don't need this extra
> checking at the moment. Just for comparison, let's take a hot function
> __io_uring_get_cqe.
Yes, I don't see any harm in removing the stack protector here.
Reviewed-by: Alviro Iskandar Setiawan <[email protected]>
-- Viro
next prev parent reply other threads:[~2022-02-24 22:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 22:24 [PATCH liburing v1] src/Makefile: Don't use stack protector for all builds by default Ammar Faizi
2022-02-24 22:33 ` Alviro Iskandar Setiawan [this message]
2022-02-25 20:29 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOG64qOgZ9bvdCV3-N=uk4ZCCj46W1VJU_+kN9ZsV8uTMnJ8-A@mail.gmail.com' \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox