Re: [PATCH v2] io_uring: reduced function parameter ctx if possible

[Jackie Liu <liuyun01@kylinos.cn>]

> 
>> 2019年11月8日 17:10，Bob Liu <bob.liu@oracle.com> 写道：
>> 
>> On 11/8/19 5:00 PM, Jackie Liu wrote:
>>> oops, please ignore this, it's crash with commit '2665abfd757fb35a241c6f0b1ebf620e3ffb36fb'
>>> I need test more, and resend later.
>>> 
>> 
>> Hmm.. io_link_cancel_timeout() may free req..
>> 
> 
> Actually, there is no problem with this patch. It is caused by a patch that I
> have not sent yet, I will send it after doing more tests.
> 

Sad. rejected by mailing list? 

@@ -714,9 +714,9 @@ static void __io_free_req(struct io_kiocb *req)
        kmem_cache_free(req_cachep, req);
 }

-static bool io_link_cancel_timeout(struct io_ring_ctx *ctx,
-                                  struct io_kiocb *req)
+static bool io_link_cancel_timeout(struct io_kiocb *req)
 {
+       struct io_ring_ctx *ctx = req->ctx;
        int ret;

        ret = hrtimer_try_to_cancel(&req->timeout.timer);

I use req directly to convert to ctx, there is no crash problem here.

--
BR, Jackie Liu