From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BC6FC4332F for ; Thu, 20 Oct 2022 08:26:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229996AbiJTI0m (ORCPT ); Thu, 20 Oct 2022 04:26:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229768AbiJTI0l (ORCPT ); Thu, 20 Oct 2022 04:26:41 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FDE4188A85; Thu, 20 Oct 2022 01:26:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nzKugFjin02AsmVSO2SO0VwhTWFBPSTkNTSFyYe251I=; b=giFg8cmWtAJ+oOhF6XZcXqFAPi jZ/26cqTs4SRs/bBLLzAIglFyvHeG1I/OG+TVy1zvB1DTnenH+rJQBm41hPJZxzV1yCvCms87Q1x6 ATqWDUE3mwDLrZvVCF9+2U4Kh3hL3H1lXjce7om1NWsEeRCgegLpZooIQVUC9YDmFbjZxU5mqz7+z 79DHJD2eHUKtEj8V/EnOBvCH7apHoICpdmevMPSDBRfFZfpqJRPz2ciiVw56pL7IGHs2WmVbheyOu 8xF7aRZF7jLWy5LctIP/N4LGJ0O7AWxdW2YLSTIAmygSn6oyPM6GxEodfZVIxguCUiuTmBACU6fOm Kf05jfww==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1olQsx-00CBhc-8o; Thu, 20 Oct 2022 08:26:39 +0000 Date: Thu, 20 Oct 2022 01:26:39 -0700 From: Christoph Hellwig To: Pavel Begunkov Cc: Jens Axboe , linux-block@vger.kernel.org, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [RFC for-next v2 1/4] bio: safeguard REQ_ALLOC_CACHE bio put Message-ID: References: <558d78313476c4e9c233902efa0092644c3d420a.1666122465.git.asml.silence@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <558d78313476c4e9c233902efa0092644c3d420a.1666122465.git.asml.silence@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Tue, Oct 18, 2022 at 08:50:55PM +0100, Pavel Begunkov wrote: > bio_put() with REQ_ALLOC_CACHE assumes that it's executed not from > an irq context. Let's add a warning if the invariant is not respected, > especially since there is a couple of places removing REQ_POLLED by hand > without also clearing REQ_ALLOC_CACHE. Looks good: Reviewed-by: Christoph Hellwig