From: Keith Busch <[email protected]>
To: Christoph Hellwig <[email protected]>
Cc: Keith Busch <[email protected]>,
[email protected], [email protected],
[email protected], [email protected],
[email protected]
Subject: Re: [PATCH 0/4] io_uring: use ITER_UBUF
Date: Tue, 8 Nov 2022 13:25:14 -0700 [thread overview]
Message-ID: <Y2q7Kn4tDlaKCVMS@kbusch-mbp> (raw)
In-Reply-To: <[email protected]>
On Mon, Nov 07, 2022 at 10:54:06PM -0800, Christoph Hellwig wrote:
> On Mon, Nov 07, 2022 at 09:56:06AM -0800, Keith Busch wrote:
> > 1. io_uring will always prefer using the _iter versions of read/write
> > callbacks if file_operations implement both, where as the generic
> > syscalls will use .read/.write (if implemented) for non-vectored IO.
>
> There are very few file operations that have both, and for those
> the difference matters, e.g. the strange vectors semantics for the
> sound code.
Yes, thankfully there are not many. Other than the two mentioned
file_operations, the only other fops I find implementing both are
'null_ops' and 'zero_ops'; those are fine. And one other implements
just .write/.write_iter: trace_events_user.c, which is also fine.
> I would strongly suggest to mirror what the normal
> read/write path does here.
I don't think we can change that now. io_uring has always used the
.{read,write}_iter callbacks if available ever since it introduced
non-vectored read/write (3a6820f2bb8a0). Altering the io_uring op's ABI
to align with the read/write syscalls seems risky.
But I don't think there are any real use cases affected by this series
anyway.
> > 2. io_uring will use the ITER_UBUF representation for single vector
> > readv/writev, but the generic syscalls currently uses ITER_IOVEC for
> > these.
>
> Same here. It might be woth to use ITER_UBUF for single vector
> readv/writev, but this should be the same for all interfaces. I'd
> suggest to drop this for now and do a separate series with careful
> review from Al for this.
I feel like that's a worthy longer term goal, but I'll start looking
into it now.
prev parent reply other threads:[~2022-11-08 20:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 17:56 [PATCH 0/4] io_uring: use ITER_UBUF Keith Busch
2022-11-07 17:56 ` [PATCH 1/4] iov: add import_ubuf() Keith Busch
2022-11-08 6:55 ` Christoph Hellwig
2022-11-08 16:05 ` Keith Busch
2022-11-07 17:56 ` [PATCH 2/4] io_uring: switch network send/recv to ITER_UBUF Keith Busch
2022-11-07 17:56 ` [PATCH 3/4] io_uring: use ubuf for single range imports for read/write Keith Busch
2022-11-07 17:56 ` [PATCH 4/4] iov_iter: move iter_ubuf check inside restore WARN Keith Busch
2022-11-08 6:54 ` [PATCH 0/4] io_uring: use ITER_UBUF Christoph Hellwig
2022-11-08 20:25 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2q7Kn4tDlaKCVMS@kbusch-mbp \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox