Re: [PATCH liburing] Alphabetise the test list

[Keith Busch <kbusch@kernel.org>]

On Tue, Nov 08, 2022 at 09:21:37AM -0800, Dylan Yudaken wrote:
> Alphabetical order is commanded by the comment at the top of the list

We could create a make target to detect this kind of thing. A quick
script off the top of my head gets pretty close to finding improper
order, though not sure how pedantic it needs to be with the dashes '-'.

$ diff -u <(sed -e '/test_srcs :=/,/EOL/!d' test/Makefile | sed '1d;$d' | sed 's/\.c//g') \
          <(sed -e '/test_srcs :=/,/EOL/!d' test/Makefile | sed '1d;$d' | sed 's/\.c//g' | sort)

--- /dev/fd/63  2022-11-08 10:11:22.040884177 -0800
+++ /dev/fd/62  2022-11-08 10:11:22.041884178 -0800
@@ -69,8 +69,8 @@
        msg-ring \
        multicqes_drain \
        nolibc \
-       nop-all-sizes \
        nop \
+       nop-all-sizes \
        openat2 \
        open-close \
        open-direct-link \
@@ -83,13 +83,13 @@
        poll-cancel \
        poll-cancel-all \
        poll-cancel-ton \
+       pollfree \
        poll-link \
        poll-many \
        poll-mshot-overflow \
        poll-mshot-update \
        poll-ring \
        poll-v-poll \
-       pollfree \
        probe \
        read-before-exit \
        read-write \
@@ -99,8 +99,8 @@
        register-restrictions \
        rename \
        ringbuf-read \
-       ring-leak2 \
        ring-leak \
+       ring-leak2 \
        rsrc_tags \
        rw_merge_test \
        self \