public inbox for [email protected]
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <[email protected]>
To: [email protected], [email protected]
Cc: Dylan Yudaken <[email protected]>,
	Dominik Thalhammer <[email protected]>,
	[email protected], [email protected]
Subject: Re: liburing 2.3 API/ABI breakage
Date: Wed, 9 Nov 2022 20:58:39 -0500	[thread overview]
Message-ID: <Y2xaz5HwrGcbKJK8@fedora> (raw)
In-Reply-To: <Y2wcUfHyS7pjlGNy@fedora>

[-- Attachment #1: Type: text/plain, Size: 659 bytes --]

> 2. Going from size_t to unsigned int is ABI breakage. This is mitigated
>    on CPU architectures that share 32-bit/64-bit registers (i.e. rax/eax
>    on x86-64 and r0/x0/w0 on aarch64). There's no guarantee this works
>    on all architectures, especially when the calling convention passes
>    arguments on the stack.

Good news, I realized that io_uring_prep_getxattr() and friends are
static inline functions. ABI breakage doesn't come into play because
they are compiled into the application.

The const char * to char * API breakage issue still remains but there's
a pretty good chance that real applications already pass in char *.

Thanks,
Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2022-11-10  2:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-09 21:32 liburing 2.3 API/ABI breakage Stefan Hajnoczi
2022-11-10  1:58 ` Stefan Hajnoczi [this message]
2022-11-10  9:43   ` Dylan Yudaken
2022-11-10 13:46     ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2xaz5HwrGcbKJK8@fedora \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox