From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9946DC636CC for ; Sun, 5 Feb 2023 00:56:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229560AbjBEA4u (ORCPT ); Sat, 4 Feb 2023 19:56:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjBEA4t (ORCPT ); Sat, 4 Feb 2023 19:56:49 -0500 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECB7822A1D for ; Sat, 4 Feb 2023 16:56:48 -0800 (PST) Received: from biznet-home.integral.gnuweeb.org (unknown [182.253.183.234]) by gnuweeb.org (Postfix) with ESMTPSA id EA65C83002; Sun, 5 Feb 2023 00:56:46 +0000 (UTC) X-GW-Data: lPqxHiMPbJw1wb7CM9QUryAGzr0yq5atzVDdxTR0iA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1675558608; bh=3JogzhmrwYuQO9ZEOJRlojOaZGokM6qq4w1PVToYJyw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OhFN+/KUTzTqNBaAanV9APp/JHgjIXQYKW43nkciL4oT4dqyqstbKs/bTvv0W1N6G WDVxfvgZLie2UbgwVUmxjaIDJS+waz0YfNfye18SUuP9ep7seoDoII7ArtXJYUvuHW eAIyILDGO795+QD88O/tWrRP+Taqv7ofcrPozPi495njAZm+bXwwWDZPMgvWL5Q0ND 6i7Z8fMi3JwnNUB3Mg9n6UXTkKxuYJisnF3BSKMMLghG+c01Qnhj9T6kqGn5JRaVW3 I8YO92n8z8SQjpLfbtKB5ucaCcv3WvK3+52xnhW/irr4AR7jeTLRbJcadvX5P+i6vD qMVSD/L5z2+/Q== Date: Sun, 5 Feb 2023 07:56:43 +0700 From: Ammar Faizi To: Stefan Roesch Cc: Facebook Kernel Team , io-uring Mailing List , Jens Axboe Subject: Re: [PATCH v7 2/4] liburing: add documentation for new napi busy polling Message-ID: References: <20230205002424.102422-1-shr@devkernel.io> <20230205002424.102422-3-shr@devkernel.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230205002424.102422-3-shr@devkernel.io> Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Sat, Feb 04, 2023 at 04:24:22PM -0800, Stefan Roesch wrote: > +The > +.BR io_uring_register_napi (3) > +function registers the NAPI settings for subsequent operations. The NAPI > +settings are specified in the structure that is passed in the > +.I napi > +parameter. The structure consists of the napi timeout > +.I busy_poll_to > +(napi busy poll timeout in us) and > +.I prefer_busy_poll. nit: That "period" after "prefer_busy_poll" will be underlined if you write it that way. It would be better if you write: .IR prefer_busy_poll . so that the dot is not underlined when you open that manpage from a terminal. But not a big deal.. Reviewed-by: Ammar Faizi -- Ammar Faizi