From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7552DC61DA4 for ; Fri, 3 Feb 2023 09:19:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232555AbjBCJTv (ORCPT ); Fri, 3 Feb 2023 04:19:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232648AbjBCJTT (ORCPT ); Fri, 3 Feb 2023 04:19:19 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22EFB449F; Fri, 3 Feb 2023 01:18:04 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 66193CE2F51; Fri, 3 Feb 2023 09:17:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12BAEC433D2; Fri, 3 Feb 2023 09:17:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675415871; bh=qXg9nkVrLq+tSzHiuxr6prwSi15LJI7uYBFEuN7cU7s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X0FXIXNsxgEE573lxDtYRDIMCVflI5UVNtHtiFFOuPmzwXT5y3dQooGfEAxkd14Br CeqCNb7gb3dX8UFzmB4FgRwIka+/89E4tohQSr8b93ZVLPTnoGkbJSSqJ8JqMdIQuA yvj8wSUcxbncnjPH+OAKSaJAn+PhhczjK79zLd9s= Date: Fri, 3 Feb 2023 10:17:48 +0100 From: Greg Kroah-Hartman To: Jens Axboe Cc: Linux regressions mailing list , "stable@vger.kernel.org" , io-uring@vger.kernel.org, LKML , "Sergey V." Subject: Re: [regression] =?iso-8859-1?Q?Bug=A02169?= =?iso-8859-1?Q?32_-_io=5Furing_with_libvir?= =?iso-8859-1?Q?t?= cause kernel NULL pointer dereference since 6.1.5 Message-ID: References: <74347fe1-ac68-2661-500d-b87fab6994f7@leemhuis.info> <0857ddf2-89a9-231b-89da-57cacc7342d5@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0857ddf2-89a9-231b-89da-57cacc7342d5@kernel.dk> Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Mon, Jan 16, 2023 at 08:50:20AM -0700, Jens Axboe wrote: > On 1/16/23 8:44 AM, Jens Axboe wrote: > > On 1/16/23 7:49 AM, Greg Kroah-Hartman wrote: > >> On Mon, Jan 16, 2023 at 07:13:40AM -0700, Jens Axboe wrote: > >>> On 1/16/23 6:42 AM, Jens Axboe wrote: > >>>> On 1/16/23 6:17?AM, Linux kernel regression tracking (Thorsten Leemhuis) wrote: > >>>>> Hi, this is your Linux kernel regression tracker. > >>>>> > >>>>> I noticed a regression report in bugzilla.kernel.org. As many (most?) > >>>>> kernel developer don't keep an eye on it, I decided to forward it by > >>>>> mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216932 : > >>>> > >>>> Looks like: > >>>> > >>>> commit 6d47e0f6a535701134d950db65eb8fe1edf0b575 > >>>> Author: Jens Axboe > >>>> Date: Wed Jan 4 08:52:06 2023 -0700 > >>>> > >>>> block: don't allow splitting of a REQ_NOWAIT bio > >>>> > >>>> got picked up by stable, but not the required prep patch: > >>>> > >>>> > >>>> commit 613b14884b8595e20b9fac4126bf627313827fbe > >>>> Author: Jens Axboe > >>>> Date: Wed Jan 4 08:51:19 2023 -0700 > >>>> > >>>> block: handle bio_split_to_limits() NULL return > >>>> > >>>> Greg/team, can you pick the latter too? It'll pick cleanly for > >>>> 6.1-stable, not sure how far back the other patch has gone yet. > >>> > >>> Looked back, and 5.15 has it too, but the cherry-pick won't work > >>> on that kernel. > >>> > >>> Here's one for 5.15-stable that I verified crashes before this one, > >>> and works with it. Haven't done an allmodconfig yet... > >> > >> All now queued up, thanks! > > > > Thanks Greg! This one was my fault, as it was a set of 2 patches and > > I only marked 2/2 for stable. But how is that best handled? 1/2 could've > > been marked stable as well, but I don't think that would have prevented > > 2/2 applying fine and 1/2 failing and hence not getting queued up until > > I would've done a backport. > > > > What's the recommended way to describe the dependency that you only > > want 2/2 applied when 1/2 is in as well? > > What I'm asking is if we have something like Depends-on or similar > that would explain this dependency. Then patch 2/2 could have: > > Depends-on: 613b14884b85 ("block: handle bio_split_to_limits() NULL return") > > and then it'd be clear that either both get added, or none of them. As per the documentation, you can put this on the cc: stable line in the changelog text like: cc: stable # 613b14884b85 thanks, greg k-h