From: Dan Carpenter <[email protected]>
To: [email protected]
Cc: [email protected]
Subject: [bug report] io_uring: add multishot mode for IORING_OP_POLL_ADD
Date: Mon, 22 Mar 2021 11:50:15 +0300 [thread overview]
Message-ID: <YFhaR/TugDDtajCb@mwanda> (raw)
Hello Jens Axboe,
This is a semi-automatic email about new static checker warnings.
The patch e7bf437da251: "io_uring: add multishot mode for
IORING_OP_POLL_ADD" from Feb 22, 2021, leads to the following Smatch
complaint:
fs/io_uring.c:5009 io_poll_double_wake()
warn: variable dereferenced before check 'poll' (see line 5004)
fs/io_uring.c
5003 return 0;
5004 if (!(poll->events & EPOLLONESHOT))
^^^^^^^^^^^^
Dereference
5005 return poll->wait.func(&poll->wait, mode, sync, key);
5006
5007 list_del_init(&wait->entry);
5008
5009 if (poll && poll->head) {
^^^^
Checked too late.
5010 bool done;
5011
regards,
dan carpenter
reply other threads:[~2021-03-22 8:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFhaR/TugDDtajCb@mwanda \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox