public inbox for [email protected]
 help / color / mirror / Atom feed
* [bug report] io_uring: add multishot mode for IORING_OP_POLL_ADD
@ 2021-03-22  8:50 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2021-03-22  8:50 UTC (permalink / raw)
  To: axboe; +Cc: io-uring

Hello Jens Axboe,

This is a semi-automatic email about new static checker warnings.

The patch e7bf437da251: "io_uring: add multishot mode for
IORING_OP_POLL_ADD" from Feb 22, 2021, leads to the following Smatch
complaint:

    fs/io_uring.c:5009 io_poll_double_wake()
    warn: variable dereferenced before check 'poll' (see line 5004)

fs/io_uring.c
  5003			return 0;
  5004		if (!(poll->events & EPOLLONESHOT))
                      ^^^^^^^^^^^^
Dereference

  5005			return poll->wait.func(&poll->wait, mode, sync, key);
  5006	
  5007		list_del_init(&wait->entry);
  5008	
  5009		if (poll && poll->head) {
                    ^^^^
Checked too late.

  5010			bool done;
  5011	

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-03-22  8:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-22  8:50 [bug report] io_uring: add multishot mode for IORING_OP_POLL_ADD Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox