From: Matthew Wilcox <[email protected]>
To: Jens Axboe <[email protected]>
Cc: io-uring <[email protected]>
Subject: Re: [PATCH] io_uring: fix xa_alloc_cycle() error return value check
Date: Fri, 20 Aug 2021 22:49:46 +0100 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On Fri, Aug 20, 2021 at 03:01:20PM -0600, Jens Axboe wrote:
> ret = xa_alloc_cyclic(&ctx->personalities, &id, (void *)creds,
> XA_LIMIT(0, USHRT_MAX), &ctx->pers_next, GFP_KERNEL);
> - if (!ret)
> - return id;
> - put_cred(creds);
> - return ret;
> + if (ret < 0) {
> + put_cred(creds);
> + return ret;
> + }
> + return id;
> }
Wouldn't you rather:
if (ret >= 0)
return id;
put_cred(creds);
return ret;
?
next prev parent reply other threads:[~2021-08-20 21:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 20:57 [PATCH] io_uring: fix xa_alloc_cycle() error return value check Jens Axboe
2021-08-20 21:01 ` Jens Axboe
2021-08-20 21:49 ` Matthew Wilcox [this message]
2021-08-20 22:05 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox