From: Al Viro <[email protected]>
To: Jens Axboe <[email protected]>
Cc: [email protected], [email protected],
[email protected]
Subject: Re: [PATCHSET v3 0/3] Add ability to save/restore iov_iter state
Date: Thu, 16 Sep 2021 04:47:59 +0000 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
Jens, may I politely inquire why is struct io_rw playing
these games with overloading ->rw.addr, instead of simply having
struct io_buffer *kbuf in it?
Another question: what the hell are the rules for
REQ_F_BUFFER_SELECT? The first time around io_iov_buffer_select()
will
* read iovec from ->rw.addr
* replace iovec.iov_base with value derived from
->buf_index
* cap iovec.iov_len with value derived from ->buf_index
Next time around it will use the same base *AND* replace the
length with the value used to cap the original.
Is that deliberate?
next prev parent reply other threads:[~2021-09-16 4:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 16:29 [PATCHSET v3 0/3] Add ability to save/restore iov_iter state Jens Axboe
2021-09-15 16:29 ` [PATCH 1/3] iov_iter: add helper to save " Jens Axboe
2021-09-15 16:29 ` [PATCH 2/3] io_uring: use iov_iter state save/restore helpers Jens Axboe
2021-09-15 16:29 ` [PATCH 3/3] Revert "iov_iter: track truncated size" Jens Axboe
2021-09-15 18:32 ` [PATCHSET v3 0/3] Add ability to save/restore iov_iter state Linus Torvalds
2021-09-15 18:46 ` Jens Axboe
2021-09-15 19:26 ` Linus Torvalds
2021-09-15 19:40 ` Jens Axboe
2021-09-15 22:42 ` Jens Axboe
2021-09-16 1:15 ` Jens Axboe
2021-09-16 4:47 ` Al Viro [this message]
2021-09-16 16:10 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox