From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1C78C433FE for ; Wed, 27 Oct 2021 14:38:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B81FB6103B for ; Wed, 27 Oct 2021 14:38:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237549AbhJ0Okz (ORCPT ); Wed, 27 Oct 2021 10:40:55 -0400 Received: from new2-smtp.messagingengine.com ([66.111.4.224]:33727 "EHLO new2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233962AbhJ0Oky (ORCPT ); Wed, 27 Oct 2021 10:40:54 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id D86C1580593; Wed, 27 Oct 2021 10:38:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 27 Oct 2021 10:38:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=EQW6ogjIJGDseBKZUZlDLFw/kgn I54KQm+3+JLexLeQ=; b=uvkRd6h6Z3Um1spyfD5prX7NogFRDqd00IzR6h9MCbi KpPsIyfw1eDNUtGsNF4NMP3hyYfOjG01KsHU2kGY1elvdUvYUxHqrJPI6f7oDbeE NiQQMyXvFdGr5axZW/jiOqVKH2gnUj+WAoBbBEgib2skoaFACaZ1bKVJr/oGOcMV qislhj+yviX7gjHE7ngXx0dKFzBxZpzFhgJpcYI/qjERefgmMvHAf4ixR++bnjWs OsoDkW8z0ZrjiPFN6z+SrQuFtMGFKTJdAgOvQxLNp22JkLK/UOX/aqOirTrB4W3V 8WBCmr7MbTjfCncmJ2lVJ3PK+kFifFY7R2gjKz7P5yQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=EQW6og jIJGDseBKZUZlDLFw/kgnI54KQm+3+JLexLeQ=; b=TtnoLK8NH2i9K7POTI4lJg RAiELU7JDt/WJqrX/wSSMUOrf41saz3QfqnpITWqOuqGqLHGtKUdEM7b4oupVxFa HTqRaX6+U5Jvou/dsu58F1VipvyNpo0FI98zPeB3IDY66Z/DFTMZQSAknqjFlNvG ZfS1vpnskGBpXgE+E1XjM9uSlUWCgl//72XUjuZZPx3kIxztVA1Wt6LYXVsHVmBT ZuW2GH9KDtkyF9r+f8sfF+qv6nuW2DtYoMoRDf9oen1UuAXWH7yy/Z0ihQjYqymJ wcYD3qWhSedZj7Y/EHZzOfZBGgyTAbpWb5d6+yZHBbfjG+5vXPO69LB297zmfiQg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdegtddgjeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucggtffrrghtthgvrhhnpeeuleeltd ehkeeltefhleduuddvhfffuedvffduveegheekgeeiffevheegfeetgfenucffohhmrghi nhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepghhrvghgsehkrhhorghhrdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 27 Oct 2021 10:38:28 -0400 (EDT) Date: Wed, 27 Oct 2021 16:38:25 +0200 From: Greg KH To: Lee Jones Cc: stable@vger.kernel.org, axboe@kernel.dk, asml.silence@gmail.com, io-uring@vger.kernel.org, syzbot+59d8a1f4e60c20c066cf@syzkaller.appspotmail.com Subject: Re: [PATCH 5.10 1/1] io_uring: fix double free in the deferred/cancelled path Message-ID: References: <20211027080128.1836624-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Wed, Oct 27, 2021 at 03:00:20PM +0100, Lee Jones wrote: > On Wed, 27 Oct 2021, Greg KH wrote: > > > On Wed, Oct 27, 2021 at 10:03:01AM +0100, Lee Jones wrote: > > > On Wed, 27 Oct 2021, Greg KH wrote: > > > > > > > On Wed, Oct 27, 2021 at 09:37:59AM +0100, Lee Jones wrote: > > > > > On Wed, 27 Oct 2021, Greg KH wrote: > > > > > > > > > > > On Wed, Oct 27, 2021 at 09:01:28AM +0100, Lee Jones wrote: > > > > > > > 792bb6eb86233 ("io_uring: don't take uring_lock during iowq cancel") > > > > > > > inadvertently fixed this issue in v5.12. This patch cherry-picks the > > > > > > > hunk of commit which does so. > > > > > > > > > > > > Why can't we take all of that commit? Why only part of it? > > > > > > > > > > I don't know. > > > > > > > > > > Why didn't the Stable team take it further than v5.11.y? > > > > > > > > Look in the archives? Did it not apply cleanly? > > > > > > > > /me goes off and looks... > > > > > > > > Looks like I asked for a backport, but no one did it, I only received a > > > > 5.11 version: > > > > https://lore.kernel.org/r/1839646480a26a2461eccc38a75e98998d2d6e11.1615375332.git.asml.silence@gmail.com > > > > > > > > so a 5.10 version would be nice, as I said it failed as-is: > > > > https://lore.kernel.org/all/161460075611654@kroah.com/ > > > > > > Precisely. This is the answer to your question: > > > > > > > > > Why can't we take all of that commit? Why only part of it? > > > > > > Same reason the Stable team didn't back-port it - it doesn't apply. > > > > > > The second hunk is only relevant to v5.11+. > > > > Great, then use the "normal" stable style, but down in the s-o-b area > > say "dropped second chunk as it is not relevant to 5.10.y". > > Just to clarify, by "normal", you mean: > > - Take the original patch > - Apply an "[ Upstream commit ]" tag (or similar) > - Remove the hunk that doesn't apply > - Make a note of the aforementioned action > - Submit to Stable Yes. > Rather than submitting a bespoke patch. Right? Correct. thanks, greg k-h