From: Christoph Hellwig <[email protected]>
To: Jens Axboe <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: [PATCH 1/4] block: add mq_ops->queue_rqs hook
Date: Thu, 16 Dec 2021 01:01:12 -0800 [thread overview]
Message-ID: <YbsAWGcCPn/[email protected]> (raw)
In-Reply-To: <[email protected]>
This whole series seems to miss a linux-block cc..
On Wed, Dec 15, 2021 at 09:24:18AM -0700, Jens Axboe wrote:
> If we have a list of requests in our plug list, send it to the driver in
> one go, if possible. The driver must set mq_ops->queue_rqs() to support
> this, if not the usual one-by-one path is used.
>
> Signed-off-by: Jens Axboe <[email protected]>
> ---
> block/blk-mq.c | 26 +++++++++++++++++++++++---
> include/linux/blk-mq.h | 8 ++++++++
> 2 files changed, 31 insertions(+), 3 deletions(-)
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index e02e7017db03..f24394cb2004 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -2512,6 +2512,7 @@ void blk_mq_flush_plug_list(struct blk_plug *plug, bool from_schedule)
> {
> struct blk_mq_hw_ctx *this_hctx;
> struct blk_mq_ctx *this_ctx;
> + struct request *rq;
> unsigned int depth;
> LIST_HEAD(list);
>
> @@ -2520,7 +2521,28 @@ void blk_mq_flush_plug_list(struct blk_plug *plug, bool from_schedule)
> plug->rq_count = 0;
>
> if (!plug->multiple_queues && !plug->has_elevator && !from_schedule) {
> + struct request_queue *q;
> +
> + rq = rq_list_peek(&plug->mq_list);
> + q = rq->q;
Nit: I'd just drop the q local variable as it is rather pointless.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <[email protected]>
next prev parent reply other threads:[~2021-12-16 9:01 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 16:24 [PATCHSET v3 0/4] Add support for list issue Jens Axboe
2021-12-15 16:24 ` [PATCH 1/4] block: add mq_ops->queue_rqs hook Jens Axboe
2021-12-16 9:01 ` Christoph Hellwig [this message]
2021-12-20 20:36 ` Keith Busch
2021-12-20 20:47 ` Jens Axboe
2021-12-15 16:24 ` [PATCH 2/4] nvme: split command copy into a helper Jens Axboe
2021-12-16 9:01 ` Christoph Hellwig
2021-12-16 12:17 ` Max Gurtovoy
2021-12-15 16:24 ` [PATCH 3/4] nvme: separate command prep and issue Jens Axboe
2021-12-16 9:02 ` Christoph Hellwig
2021-12-15 16:24 ` [PATCH 4/4] nvme: add support for mq_ops->queue_rqs() Jens Axboe
2021-12-15 17:29 ` Keith Busch
2021-12-15 20:27 ` Jens Axboe
2021-12-16 9:08 ` Christoph Hellwig
2021-12-16 13:06 ` Max Gurtovoy
2021-12-16 15:48 ` Jens Axboe
2021-12-16 16:00 ` Max Gurtovoy
2021-12-16 16:05 ` Jens Axboe
2021-12-16 16:19 ` Max Gurtovoy
2021-12-16 16:25 ` Jens Axboe
2021-12-16 16:34 ` Max Gurtovoy
2021-12-16 16:36 ` Jens Axboe
2021-12-16 16:57 ` Max Gurtovoy
2021-12-16 17:16 ` Jens Axboe
2021-12-19 12:14 ` Max Gurtovoy
2021-12-19 14:48 ` Jens Axboe
2021-12-20 10:11 ` Max Gurtovoy
2021-12-20 14:19 ` Jens Axboe
2021-12-20 14:25 ` Jens Axboe
2021-12-20 15:29 ` Max Gurtovoy
2021-12-20 16:34 ` Jens Axboe
2021-12-20 18:48 ` Max Gurtovoy
2021-12-20 18:58 ` Jens Axboe
2021-12-21 10:20 ` Max Gurtovoy
2021-12-21 15:23 ` Jens Axboe
2021-12-21 15:29 ` Max Gurtovoy
2021-12-21 15:33 ` Jens Axboe
2021-12-21 16:08 ` Max Gurtovoy
2021-12-16 15:45 ` Jens Axboe
2021-12-16 16:15 ` Christoph Hellwig
2021-12-16 16:27 ` Jens Axboe
2021-12-16 16:30 ` Christoph Hellwig
2021-12-16 16:36 ` Jens Axboe
2021-12-16 13:02 ` Max Gurtovoy
2021-12-16 15:59 ` Jens Axboe
2021-12-16 16:06 ` Max Gurtovoy
2021-12-16 16:09 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2021-12-16 16:05 [PATCHSET v4 0/4] Add support for list issue Jens Axboe
2021-12-16 16:05 ` [PATCH 1/4] block: add mq_ops->queue_rqs hook Jens Axboe
2021-12-16 16:38 [PATCHSET v5 0/4] Add support for list issue Jens Axboe
2021-12-16 16:38 ` [PATCH 1/4] block: add mq_ops->queue_rqs hook Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbsAWGcCPn/[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox