From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23B43C433F5 for ; Thu, 16 Dec 2021 09:01:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229939AbhLPJBv (ORCPT ); Thu, 16 Dec 2021 04:01:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229555AbhLPJBv (ORCPT ); Thu, 16 Dec 2021 04:01:51 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BC66C061574 for ; Thu, 16 Dec 2021 01:01:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3Thh0nXZnceqNDdds5eXbcz6jycQJGEnJOLIzCBHNA4=; b=q0T8n7DfJ5n9RgJfiSNLMXrBfc 88InHbUwpQrXaVKlCKCffi3rAHSoJdbfn7cSCa3wewWrBWsHQdW0+T2LbyfZuP8QqQirBt5Rhz65P wZrpCc52FEBTSOcwIBGRdKXyPtWSbzoPKv02zr2iZwLbmU7S4dRhWKu28BGiqrnPBj2w/XxDJOq4g RlTXQelZKkEezLOMr4/JL9oC986D00M2BmiznQMcT/OovJ4ODOkoxO0EYd7s1zI8y0HGLWJSJcstV r+zaT0zHKft3hXxmV2CIETGsx3Z5c7yZ+gBS7/YJOnWJWN7mCuUQlZxkI/OY4YXK760PIUH4bXrFZ FFGv4mHg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxme6-004G2Y-HM; Thu, 16 Dec 2021 09:01:50 +0000 Date: Thu, 16 Dec 2021 01:01:50 -0800 From: Christoph Hellwig To: Jens Axboe Cc: io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, Chaitanya Kulkarni , Hannes Reinecke Subject: Re: [PATCH 2/4] nvme: split command copy into a helper Message-ID: References: <20211215162421.14896-1-axboe@kernel.dk> <20211215162421.14896-3-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211215162421.14896-3-axboe@kernel.dk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Just like the two times before: NAK. Please remove nvme_submit_cmd and open code it in the two callers.