From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DA14C433EF for ; Mon, 14 Mar 2022 14:41:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229603AbiCNOmY (ORCPT ); Mon, 14 Mar 2022 10:42:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233560AbiCNOmX (ORCPT ); Mon, 14 Mar 2022 10:42:23 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4619712AAA for ; Mon, 14 Mar 2022 07:41:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647268873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CerS4a8OUZGYW+X8CS5QhG576h4KjCig00kFCIeH3Dg=; b=RYmb8J4q6z42Q+bDZql8HvVxHmdMZeIcTGY45h7CvaASPWE96cc87J5SAS7rmdpg9SBpN7 hLde4m8AMGmi5EsWmO81pqBlAjo9wqekiaW3MkjSDmXj0Y2dEA6M80Zq/TRn9mfXXJnfvA KmO6Sqr4bsqOt/Y/fGj6i98R/0+Pq3U= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-49-GIcs86ffO8SR6ecWw880HQ-1; Mon, 14 Mar 2022 10:41:08 -0400 X-MC-Unique: GIcs86ffO8SR6ecWw880HQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 26E211C01506; Mon, 14 Mar 2022 14:41:07 +0000 (UTC) Received: from T590 (ovpn-8-17.pek2.redhat.com [10.72.8.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 995B5145B961; Mon, 14 Mar 2022 14:40:58 +0000 (UTC) Date: Mon, 14 Mar 2022 22:40:53 +0800 From: Ming Lei To: Kanchan Joshi Cc: Christoph Hellwig , Kanchan Joshi , Jens Axboe , Keith Busch , Pavel Begunkov , io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, sbates@raithlin.com, logang@deltatee.com, Pankaj Raghav , Javier =?iso-8859-1?Q?Gonz=E1lez?= , Luis Chamberlain , Adam Manzanares , Anuj Gupta Subject: Re: [PATCH 10/17] block: wire-up support for plugging Message-ID: References: <20220308152105.309618-1-joshi.k@samsung.com> <20220308152105.309618-11-joshi.k@samsung.com> <20220310083400.GD26614@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Thu, Mar 10, 2022 at 06:10:08PM +0530, Kanchan Joshi wrote: > On Thu, Mar 10, 2022 at 2:04 PM Christoph Hellwig wrote: > > > > On Tue, Mar 08, 2022 at 08:50:58PM +0530, Kanchan Joshi wrote: > > > From: Jens Axboe > > > > > > Add support to use plugging if it is enabled, else use default path. > > > > The subject and this comment don't really explain what is done, and > > also don't mention at all why it is done. > > Missed out, will fix up. But plugging gave a very good hike to IOPS. But how does plugging improve IOPS here for passthrough request? Not see plug->nr_ios is wired to data.nr_tags in blk_mq_alloc_request(), which is called by nvme_submit_user_cmd(). Thanks, Ming