From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E576C25B07 for ; Wed, 10 Aug 2022 18:52:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231409AbiHJSwe (ORCPT ); Wed, 10 Aug 2022 14:52:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229567AbiHJSwd (ORCPT ); Wed, 10 Aug 2022 14:52:33 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 273F882FA4; Wed, 10 Aug 2022 11:52:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=30VFo5a7JeVy/w8TY1J+NJC1egtewPVjD1FM6RGYwBg=; b=s6a64YP8QczXD0JIqbxeiDGFqS Sb/NlyQn4cZX6wLkeYRRQJZ5VKHXw5xK4FKWP00CCewYp9T3RgVmy9/p3NDkxPaQgwaTy6Ds4i8My bNzcWFX0WFEIzg18D3mehTWJSl0H3V/YCa3T1RzgQSsGvoZAxvCgQciLnCn1FOT9JxTYPOUkp5AkH WaSAhTo2r/YXVFA2Di8jdzsQsz8Wo1ZabEUXKjvIrsu9PazM6slOdEANhDJcHgrJuEPmEMXv2ScT2 rtb7kwooxIN0gRkh3xIyHPaN4Shz2qMltQj/+wXHU8/KjiUdflrMV6X1IH/BAScfYYMVLzKE1Licv 8wwjLBdw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oLqoc-00DuFN-CR; Wed, 10 Aug 2022 18:52:26 +0000 Date: Wed, 10 Aug 2022 11:52:26 -0700 From: Luis Chamberlain To: Paul Moore Cc: Jens Axboe , Ming Lei , casey@schaufler-ca.com, joshi.k@samsung.com, Linus Torvalds , linux-security-module@vger.kernel.org, io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, a.manzanares@samsung.com, javier@javigon.com Subject: Re: [PATCH v2] lsm,io_uring: add LSM hooks for the new uring_cmd file op Message-ID: References: <20220715191622.2310436-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Wed, Aug 10, 2022 at 02:39:54PM -0400, Paul Moore wrote: > On Wed, Aug 10, 2022 at 2:14 PM Luis Chamberlain wrote: > > > > On Fri, Jul 15, 2022 at 01:28:35PM -0600, Jens Axboe wrote: > > > On 7/15/22 1:16 PM, Luis Chamberlain wrote: > > > > io-uring cmd support was added through ee692a21e9bf ("fs,io_uring: > > > > add infrastructure for uring-cmd"), this extended the struct > > > > file_operations to allow a new command which each subsystem can use > > > > to enable command passthrough. Add an LSM specific for the command > > > > passthrough which enables LSMs to inspect the command details. > > > > > > > > This was discussed long ago without no clear pointer for something > > > > conclusive, so this enables LSMs to at least reject this new file > > > > operation. > > > > > > From an io_uring perspective, this looks fine to me. It may be easier if > > > I take this through my tree due to the moving of the files, or the > > > security side can do it but it'd have to then wait for merge window (and > > > post io_uring branch merge) to do so. Just let me know. If done outside > > > of my tree, feel free to add: > > > > > > Acked-by: Jens Axboe > > > > Paul, Casey, Jens, > > > > should this be picked up now that we're one week into the merge window? > > Your timing is spot on! I wrapped up a SELinux/SCTP issue by posting > the patches yesterday and started on the io_uring/CMD patches this > morning :) > > Give me a few days to get this finished, tested, etc. and I'll post a > patchset with your main patch, the Smack patch from Casey, the SELinux > patch, and the /dev/null patch so we can all give it a quick sanity > check before I merge it into the LSM/stable branch and send it to > Linus. Does that sound okay? Works with me! But just note I'll be away on vacation starting tomorrow in the woods looking for Bigfoot with my dog, so I won't be around. And I suspect Linus plans to release 6.0 on Sunday, if the phb-crystall-ball [0] is still as accurate. [0] http://deb.tandrin.de/phb-crystal-ball.htm Luis