From: Joe Damato <[email protected]>
To: Stefano Jordhani <[email protected]>
Cc: [email protected], "Paolo Abeni" <[email protected]>,
"Alexander Viro" <[email protected]>,
"Christian Brauner" <[email protected]>,
"Jan Kara" <[email protected]>,
"David S. Miller" <[email protected]>,
"Eric Dumazet" <[email protected]>,
"Jakub Kicinski" <[email protected]>,
"Simon Horman" <[email protected]>, "Jens Axboe" <[email protected]>,
"Pavel Begunkov" <[email protected]>,
"Kuniyuki Iwashima" <[email protected]>,
"Willem de Bruijn" <[email protected]>,
"Björn Töpel" <[email protected]>,
"Magnus Karlsson" <[email protected]>,
"Maciej Fijalkowski" <[email protected]>,
"Jonathan Lemon" <[email protected]>,
"Alexei Starovoitov" <[email protected]>,
"Daniel Borkmann" <[email protected]>,
"Jesper Dangaard Brouer" <[email protected]>,
"John Fastabend" <[email protected]>,
"Sebastian Andrzej Siewior" <[email protected]>,
"Lorenzo Bianconi" <[email protected]>,
"Alexander Lobakin" <[email protected]>,
"Sridhar Samudrala" <[email protected]>,
"Xuan Zhuo" <[email protected]>,
"Mina Almasry" <[email protected]>,
"open list:FILESYSTEMS (VFS and infrastructure)"
<[email protected]>,
"open list" <[email protected]>,
"open list:IO_URING" <[email protected]>,
"open list:XDP SOCKETS (AF_XDP)" <[email protected]>
Subject: Re: [PATCH net-next] net: use napi_id_valid helper
Date: Wed, 12 Feb 2025 14:45:12 -0800 [thread overview]
Message-ID: <Z60keJDOL_50cGbY@LQ3V64L9R2> (raw)
In-Reply-To: <CAEEYqun=uM-VuWZJ5puHnyp7CY06fr5kOU3hYwnOG+AydhhmNA@mail.gmail.com>
On Wed, Feb 12, 2025 at 04:15:05PM -0500, Stefano Jordhani wrote:
> In commit 6597e8d35851 ("netdev-genl: Elide napi_id when not present"),
> napi_id_valid function was added. Use the helper to refactor open-coded
> checks in the source.
>
> Suggested-by: Paolo Abeni <[email protected]>
> Signed-off-by: Stefano Jordhani <[email protected]>
> ---
> fs/eventpoll.c | 8 ++++----
> include/net/busy_poll.h | 4 ++--
> io_uring/napi.c | 4 ++--
> net/core/dev.c | 6 +++---
> net/core/netdev-genl.c | 2 +-
> net/core/page_pool_user.c | 2 +-
> net/core/sock.c | 2 +-
> net/xdp/xsk.c | 2 +-
> 8 files changed, 15 insertions(+), 15 deletions(-)
Thanks for the cleanup. As far as I can tell, LGTM.
Reviewed-by: Joe Damato <[email protected]>
next prev parent reply other threads:[~2025-02-12 22:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 21:15 [PATCH net-next] net: use napi_id_valid helper Stefano Jordhani
2025-02-12 22:45 ` Joe Damato [this message]
2025-02-12 22:52 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z60keJDOL_50cGbY@LQ3V64L9R2 \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox