public inbox for [email protected]
 help / color / mirror / Atom feed
From: Ming Lei <[email protected]>
To: Caleb Sander Mateos <[email protected]>
Cc: Keith Busch <[email protected]>, Jens Axboe <[email protected]>,
	[email protected], [email protected],
	[email protected]
Subject: Re: [PATCH] ublk: complete command synchronously on error
Date: Wed, 26 Feb 2025 17:15:43 +0800	[thread overview]
Message-ID: <Z77bv8CNoPiwaf1o@fedora> (raw)
In-Reply-To: <[email protected]>

On Tue, Feb 25, 2025 at 02:24:55PM -0700, Caleb Sander Mateos wrote:
> In case of an error, ublk's ->uring_cmd() functions currently return
> -EIOCBQUEUED and immediately call io_uring_cmd_done(). -EIOCBQUEUED and
> io_uring_cmd_done() are intended for asynchronous completions. For
> synchronous completions, the ->uring_cmd() function can just return the
> negative return code directly. This skips io_uring_cmd_del_cancelable(),
> and deferring the completion to task work. So return the error code
> directly from __ublk_ch_uring_cmd() and ublk_ctrl_uring_cmd().
> 
> Update ublk_ch_uring_cmd_cb(), which currently ignores the return value
> from __ublk_ch_uring_cmd(), to call io_uring_cmd_done() for synchronous
> completions.
> 
> Signed-off-by: Caleb Sander Mateos <[email protected]>

Reviewed-by: Ming Lei <[email protected]>

Thanks,
Ming


  parent reply	other threads:[~2025-02-26  9:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-25 21:24 [PATCH] ublk: complete command synchronously on error Caleb Sander Mateos
2025-02-25 21:29 ` Keith Busch
2025-02-26  9:15 ` Ming Lei [this message]
2025-02-26 14:32 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z77bv8CNoPiwaf1o@fedora \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox