From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D858B70825 for ; Tue, 18 Mar 2025 00:51:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742259073; cv=none; b=Fm5yI1r8j4EiNJBuxWhXLY6HoripE0qGa6Y4NcLCBUjUfczFPdN80IEmXfIeDgbFO+S5UMd7G2ZUE3C8NrphKqCRnF0qzWlTGY7HpM7nJeTixfYD9ENdpdGhxq60JlMLGnhS+4DjT1Bgyr56x1H1iMqVlLSE8cyqGXd/pZPCFkk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742259073; c=relaxed/simple; bh=FhDT6Ht4uOnAjRnAHtxZUZhftn3nLJ2mhdwA/rIdKqs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NKCLW1fCMpG/kA60zLU4BFyDUgWO3RhnsER9AUxA4dPCQVrBf4Gwwwn31Aq3+Xi5BwXQ+GgxdVOq4/KzWz+BbGF7h3B1lLIzdR2C/b3rtNLrMzSzn3EBYzpIEZsSYbBMzbN0Wyq4+HinUKkDkfYhIl/yz/DW4d80Z1Gcsr9M2pc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=furiosa.ai; spf=none smtp.mailfrom=furiosa.ai; dkim=pass (1024-bit key) header.d=furiosa.ai header.i=@furiosa.ai header.b=XQvplfzX; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=furiosa.ai Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=furiosa.ai Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=furiosa.ai header.i=@furiosa.ai header.b="XQvplfzX" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-22349bb8605so107934335ad.0 for ; Mon, 17 Mar 2025 17:51:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=furiosa.ai; s=google; t=1742259070; x=1742863870; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=U/GqRqFocBuzF9Eb/f/joYEbo/0mtodFRieL+22DCbs=; b=XQvplfzXSdtr34ongeYiAJ/wo4zOYZOAmw7kYFk2wZUyODDHhkUo9bA+UNzqbJcOSF 7tgRZEcuteivw0ehMX6iZ7xSkEffqJ45Dcrr7bHkvaBtClmg31hfVSu0niLZHhLSp0AC WtCVUH6kL98Kj9VbvQfrs0eA5sFrKZenvo72s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742259070; x=1742863870; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U/GqRqFocBuzF9Eb/f/joYEbo/0mtodFRieL+22DCbs=; b=S3H4FxocjgmdqJC7yQo8x6G2ycoIoLzizWmw6/+YAM4JIldqUYNJg264iy8CCYld5+ 6vj+aPEVhA14CRTtwBICDA+FRCKUaWxrIrDgNV2EzwTAnCqWiz5f3pgPGqolDYFzd52I LykWbcqeyPFDTy5h0WYvYvR5qcSbXKzGE/bzDkpO6EnwZg5jKo9OIMkkK0vRVZzHWVBF bqqhTj4M+DicGjs5fKn4oXcXfb6yXCJ2s1tZJXU8r4G8HMAnzWqn1apsKFEUOXCPgMVL qAXnUS7p/IAU8LTJwylzIunOpyKZmEiGGpW+e7bslVmvJ44MyKEwIuxQ0uwMXTcXGe1E Mv1Q== X-Forwarded-Encrypted: i=1; AJvYcCUv85VPls+8Fw4Du6XX42VRYCUIjPGoJkuRlCCIvnIevDgqqyfJNt4NBTZJ1w8YHFAG0Dir5fxRkw==@vger.kernel.org X-Gm-Message-State: AOJu0YwLd/uqconInvWVl1c8uB5s24jAUyfhk2+gqpKBCisdBj8+mk7r C4AMfjwIh1qU4NM4wFTup+4YbxbexF/S5HJ+junS32y8/z3s7k2po1m2yl8oCPQ= X-Gm-Gg: ASbGncsNimGN5co39QAEaIy0JBMTE0YCULq8hbhZNQecUqiFkCVoJ69DuknusJpVqN9 Nu8DS8mxt+wXXFz96nDC12CuPXAI4TES1WOgwvBXlEj/ZKvwDu8BPptsEMgWqFzGDc9wDpyL8ef ujjBzL9UXt96nj7AYpHoSUSD5KWOp9zNkahyCkff3raXaipk7B3n76JOzgIhblOAQDEI7w/vaTh wuM07G7EkbCQKO7Sf0pAljyKNsmHptNZMi5BmYYf+mdye3xx1v7jH6XvSsb9I1l0/uU791VKg+j lgS5RfI8xTrQcLOGsyi9VbkPq0TlVIQP3Usxs1YUqmPUYpfuFMvJPdAbF234+SwJBF82IOxe/4o C X-Google-Smtp-Source: AGHT+IFCTe5n82yUGpowrbpfL0mcn1Bw7/SjhqpalmHXGc+c3b40e/vG3uqcukMNwusAsrCQ70GyTw== X-Received: by 2002:a17:902:d54f:b0:215:9bc2:42ec with SMTP id d9443c01a7336-225e0b14fb5mr171079355ad.47.1742259070107; Mon, 17 Mar 2025 17:51:10 -0700 (PDT) Received: from sidongui-MacBookPro.local ([221.148.76.1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c6ba6ca3sm82072255ad.134.2025.03.17.17.51.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Mar 2025 17:51:09 -0700 (PDT) Date: Tue, 18 Mar 2025 09:51:05 +0900 From: Sidong Yang To: Caleb Sander Mateos Cc: Josef Bacik , David Sterba , Jens Axboe , Pavel Begunkov , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, io-uring@vger.kernel.org Subject: Re: [RFC PATCH v4 4/5] btrfs: ioctl: introduce btrfs_uring_import_iovec() Message-ID: References: <20250317135742.4331-1-sidong.yang@furiosa.ai> <20250317135742.4331-5-sidong.yang@furiosa.ai> Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Mar 17, 2025 at 08:37:04AM -0700, Caleb Sander Mateos wrote: > On Mon, Mar 17, 2025 at 7:00 AM Sidong Yang wrote: > > > > This patch introduces btrfs_uring_import_iovec(). In encoded read/write > > with uring cmd, it uses import_iovec without supporting fixed buffer. > > btrfs_using_import_iovec() could use fixed buffer if cmd flags has > > IORING_URING_CMD_FIXED. > > > > Signed-off-by: Sidong Yang > > --- > > fs/btrfs/ioctl.c | 32 ++++++++++++++++++++++++-------- > > 1 file changed, 24 insertions(+), 8 deletions(-) > > > > diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c > > index 6c18bad53cd3..a7b52fd99059 100644 > > --- a/fs/btrfs/ioctl.c > > +++ b/fs/btrfs/ioctl.c > > @@ -4802,6 +4802,28 @@ struct btrfs_uring_encoded_data { > > struct iov_iter iter; > > }; > > > > +static int btrfs_uring_import_iovec(struct io_uring_cmd *cmd, > > + unsigned int issue_flags, int rw) > > +{ > > + struct btrfs_uring_encoded_data *data = > > + io_uring_cmd_get_async_data(cmd)->op_data; > > + int ret; > > + > > + if (cmd && (cmd->flags & IORING_URING_CMD_FIXED)) { > > + data->iov = NULL; > > + ret = io_uring_cmd_import_fixed_vec(cmd, data->args.iov, > > + data->args.iovcnt, > > + ITER_DEST, issue_flags, > > Why ITER_DEST instead of rw? Oh, it's a mistake. It should be rw. Thanks, Sidong > > Best, > Caleb > > > + &data->iter); > > + } else { > > + data->iov = data->iovstack; > > + ret = import_iovec(rw, data->args.iov, data->args.iovcnt, > > + ARRAY_SIZE(data->iovstack), &data->iov, > > + &data->iter); > > + } > > + return ret; > > +} > > + > > static int btrfs_uring_encoded_read(struct io_uring_cmd *cmd, unsigned int issue_flags) > > { > > size_t copy_end_kernel = offsetofend(struct btrfs_ioctl_encoded_io_args, flags); > > @@ -4874,10 +4896,7 @@ static int btrfs_uring_encoded_read(struct io_uring_cmd *cmd, unsigned int issue > > goto out_acct; > > } > > > > - data->iov = data->iovstack; > > - ret = import_iovec(ITER_DEST, data->args.iov, data->args.iovcnt, > > - ARRAY_SIZE(data->iovstack), &data->iov, > > - &data->iter); > > + ret = btrfs_uring_import_iovec(cmd, issue_flags, ITER_DEST); > > if (ret < 0) > > goto out_acct; > > > > @@ -5022,10 +5041,7 @@ static int btrfs_uring_encoded_write(struct io_uring_cmd *cmd, unsigned int issu > > if (data->args.len > data->args.unencoded_len - data->args.unencoded_offset) > > goto out_acct; > > > > - data->iov = data->iovstack; > > - ret = import_iovec(ITER_SOURCE, data->args.iov, data->args.iovcnt, > > - ARRAY_SIZE(data->iovstack), &data->iov, > > - &data->iter); > > + ret = btrfs_uring_import_iovec(cmd, issue_flags, ITER_SOURCE); > > if (ret < 0) > > goto out_acct; > > > > -- > > 2.43.0 > > > >