From: Sidong Yang <[email protected]>
To: Pavel Begunkov <[email protected]>
Cc: Josef Bacik <[email protected]>,
David Sterba <[email protected]>, Jens Axboe <[email protected]>,
[email protected], [email protected],
[email protected], Mark Harmstone <[email protected]>
Subject: Re: [RFC PATCH v4 5/5] btrfs: ioctl: don't free iov when -EAGAIN in uring encoded read
Date: Tue, 18 Mar 2025 16:58:20 +0900 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On Tue, Mar 18, 2025 at 07:21:00AM +0000, Pavel Begunkov wrote:
> On 3/17/25 13:57, Sidong Yang wrote:
> > This patch fixes a bug on encoded_read. In btrfs_uring_encoded_read(),
> > btrfs_encoded_read could return -EAGAIN when receiving requests concurrently.
> > And data->iov goes to out_free and it freed and return -EAGAIN. io-uring
> > subsystem would call it again and it doesn't reset data. And data->iov
> > freed and iov_iter reference it. iov_iter would be used in
> > btrfs_uring_read_finished() and could be raise memory bug.
>
> Fixes should go first. Please send it separately, and CC Mark.
> A "Fixes" tag would also be good to have.
Okay, I'll remove this from patch series.
Thanks,
Sidong
>
> > Signed-off-by: Sidong Yang <[email protected]>
> > ---
> > fs/btrfs/ioctl.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
> > index a7b52fd99059..02fa8dd1a3ce 100644
> > --- a/fs/btrfs/ioctl.c
> > +++ b/fs/btrfs/ioctl.c
> > @@ -4922,6 +4922,9 @@ static int btrfs_uring_encoded_read(struct io_uring_cmd *cmd, unsigned int issue
> > ret = btrfs_encoded_read(&kiocb, &data->iter, &data->args, &cached_state,
> > &disk_bytenr, &disk_io_size);
> > +
> > + if (ret == -EAGAIN)
> > + goto out_acct;
> > if (ret < 0 && ret != -EIOCBQUEUED)
> > goto out_free;
>
> --
> Pavel Begunkov
>
next prev parent reply other threads:[~2025-03-18 7:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 13:57 [RFC PATCH v4 0/5] introduce io_uring_cmd_import_fixed_vec Sidong Yang
2025-03-17 13:57 ` [RFC PATCH v4 1/5] io_uring/cmd: introduce io_async_cmd for hide io_uring_cmd_data Sidong Yang
2025-03-17 13:57 ` [RFC PATCH v4 2/5] io-uring/cmd: add iou_vec field for io_uring_cmd Sidong Yang
2025-03-17 13:57 ` [RFC PATCH v4 3/5] io-uring/cmd: introduce io_uring_cmd_import_fixed_vec Sidong Yang
2025-03-17 13:57 ` [RFC PATCH v4 4/5] btrfs: ioctl: introduce btrfs_uring_import_iovec() Sidong Yang
2025-03-17 15:37 ` Caleb Sander Mateos
2025-03-18 0:51 ` Sidong Yang
2025-03-17 15:40 ` Jens Axboe
2025-03-18 1:58 ` Sidong Yang
2025-03-18 7:25 ` Pavel Begunkov
2025-03-18 7:55 ` Sidong Yang
2025-03-18 13:18 ` Jens Axboe
2025-03-17 13:57 ` [RFC PATCH v4 5/5] btrfs: ioctl: don't free iov when -EAGAIN in uring encoded read Sidong Yang
2025-03-18 7:21 ` Pavel Begunkov
2025-03-18 7:58 ` Sidong Yang [this message]
2025-03-18 7:30 ` [RFC PATCH v4 0/5] introduce io_uring_cmd_import_fixed_vec Pavel Begunkov
2025-03-18 7:41 ` Sidong Yang
2025-03-18 13:19 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox