From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3490C78F2E for ; Tue, 18 Mar 2025 07:58:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742284706; cv=none; b=TnQLZYhBn2KZuegNjETNnSAgW3YxDeMmvRG2xDu6aHynKyBLXzuYzZEzpbFcIqQCNmpnMoQ2i53lEWXJCr+c7xaBeBR7+pH1Bebyr5aK6ZanwucCekTOf8uCnoosfX3aZQc1qTRlZo+voeJHVWhKH2ZpaiqalamWc6j/a/3/1Tg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742284706; c=relaxed/simple; bh=al49eM+1tgW5ACzH7lMAhrHbpJE/ZKJWrX8DKNsNMbg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=d4LANlKsWIKtjNVAznHhF+CDJtXvlJABxmwaK+QaOWTfyY50q7jK2s7iaM+sOym47/ET4e29oAoZuC7zBJ3hSnG8dArW9gRZr/fVPqjEvGxKg2uVTSxFZMhEDrgYQSSXl4rRg/GYGksVqS57AQgs/eNxXvei0PpYnWOYkaNmvbg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=furiosa.ai; spf=none smtp.mailfrom=furiosa.ai; dkim=pass (1024-bit key) header.d=furiosa.ai header.i=@furiosa.ai header.b=k1kq3hUL; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=furiosa.ai Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=furiosa.ai Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=furiosa.ai header.i=@furiosa.ai header.b="k1kq3hUL" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-224019ad9edso50823755ad.1 for ; Tue, 18 Mar 2025 00:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=furiosa.ai; s=google; t=1742284704; x=1742889504; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JjqSNVE0Cph4A/90eA+y7Se4Hin9uKNNKIYlFXcRpQc=; b=k1kq3hULFaIoP60zLinyPlm/oWo3dzLfE6C/8xathyU6CcfVrKNNf72Z4uGsMSV3un IGt3+dLehqa64pOQym5tZIbF3jNhvBUH3jfrAemiyfFa+bYlDuS1F/8jLMYg2MlEmo44 y+AwC5WMR5BmSw6/XcqJtnAH1RblIEvmWx3mc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742284704; x=1742889504; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JjqSNVE0Cph4A/90eA+y7Se4Hin9uKNNKIYlFXcRpQc=; b=rVheaJbGfeAHVEmRy5sil0SBRjyfmpDkPjzvSGH32Rwfs2xqDoy7PbQgglJNUC8kle sg+ExwAfX3o+8I4d/ctak0uvsHP3n1EH+DUIoVNafc/8MLGrq1/w2ySl8Pzp7gXwD99b 0bvUTncF0GkNPuTZ2jzdPJdtO4ZGK4Z+VPxLMEE1nWyQhQ+iRCFWNqwTYJlI2nF0JELQ e/H2N5OOHUUnDMiiGXj+Q9fjUr6ddYrcOuG3Ief9lXqByJwO3bMn7jUspSyCH1khDzq1 6lBG+hRJ83nP2Lg72j9UzAmheAuYqxRJUUVZUJLV2p4xLpbf+rg+TTIJYfI/kRvZPi/v nV4A== X-Forwarded-Encrypted: i=1; AJvYcCVR7oFR39rkRh6qUmFjUxCUsrYIfAkdjsdPtUWUTdkQ6h9sck/FsQYnHY+FODRdDSaUUSdsQOewQA==@vger.kernel.org X-Gm-Message-State: AOJu0YxMXhGmjbY4z61RSX7PyIeHXtH56jtdsR1wi7uw4RGoVeSoSheY lCifbyZxHMseIsBP08fikZIvbHnxm3yyLRkxUrh2BxCyIrx955NH39uup1sPjWY= X-Gm-Gg: ASbGnctesIfiW+2Uhgp6dkWQQ8OR4OIi+aBqXQURucV2iJnTFH4p4riCPqGRWPwMHig kl9Kt/mTzLqz9ZdzMeuQyVs+bBepcilM2DMsJ5UzcmU7fg0fl6ejVrBpzswvj3qnxJhAA/AvH9e pr5BQgW3MA5P38dF6Ogs/0mVH265j54sqB3fvKHBfaHukQ95FwpP98CM9+K/CpAaN9RCA2Lv0Qt 9g7LuNVzV1/f6Frer/S8rcmbXJP/whqxo5bWzReA8JlqfsFy2HW8xPfi8ih4BkVS2RYZwWkzJuW q0bxOE8HSQA69+BF12IrR3UVfRW7F30ywHJP4SSN9IDCZlxrsC55cpllEkoU3xL2qtoR6bgGnMK g X-Google-Smtp-Source: AGHT+IFoYIbKKLN/4JYODjVS6d9sUEzicBL53lbs5mcV9y8CEd9goF6jVujShbqHMNdGwaaPjoahMQ== X-Received: by 2002:a17:902:f711:b0:224:b60:3ce0 with SMTP id d9443c01a7336-2262c515130mr30785105ad.5.1742284704551; Tue, 18 Mar 2025 00:58:24 -0700 (PDT) Received: from sidongui-MacBookPro.local ([221.148.76.1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c6889eeesm88219725ad.29.2025.03.18.00.58.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Mar 2025 00:58:24 -0700 (PDT) Date: Tue, 18 Mar 2025 16:58:20 +0900 From: Sidong Yang To: Pavel Begunkov Cc: Josef Bacik , David Sterba , Jens Axboe , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, io-uring@vger.kernel.org, Mark Harmstone Subject: Re: [RFC PATCH v4 5/5] btrfs: ioctl: don't free iov when -EAGAIN in uring encoded read Message-ID: References: <20250317135742.4331-1-sidong.yang@furiosa.ai> <20250317135742.4331-6-sidong.yang@furiosa.ai> <849ce82d-d87a-428a-be79-abdeb53a1a99@gmail.com> Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <849ce82d-d87a-428a-be79-abdeb53a1a99@gmail.com> On Tue, Mar 18, 2025 at 07:21:00AM +0000, Pavel Begunkov wrote: > On 3/17/25 13:57, Sidong Yang wrote: > > This patch fixes a bug on encoded_read. In btrfs_uring_encoded_read(), > > btrfs_encoded_read could return -EAGAIN when receiving requests concurrently. > > And data->iov goes to out_free and it freed and return -EAGAIN. io-uring > > subsystem would call it again and it doesn't reset data. And data->iov > > freed and iov_iter reference it. iov_iter would be used in > > btrfs_uring_read_finished() and could be raise memory bug. > > Fixes should go first. Please send it separately, and CC Mark. > A "Fixes" tag would also be good to have. Okay, I'll remove this from patch series. Thanks, Sidong > > > Signed-off-by: Sidong Yang > > --- > > fs/btrfs/ioctl.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c > > index a7b52fd99059..02fa8dd1a3ce 100644 > > --- a/fs/btrfs/ioctl.c > > +++ b/fs/btrfs/ioctl.c > > @@ -4922,6 +4922,9 @@ static int btrfs_uring_encoded_read(struct io_uring_cmd *cmd, unsigned int issue > > ret = btrfs_encoded_read(&kiocb, &data->iter, &data->args, &cached_state, > > &disk_bytenr, &disk_io_size); > > + > > + if (ret == -EAGAIN) > > + goto out_acct; > > if (ret < 0 && ret != -EIOCBQUEUED) > > goto out_free; > > -- > Pavel Begunkov >