From: Keith Busch <[email protected]>
To: Jens Axboe <[email protected]>
Cc: Keith Busch <[email protected]>,
[email protected], [email protected],
Pavel Begunkov <[email protected]>
Subject: Re: [PATCH] blk-mq: remove hybrid polling
Date: Mon, 20 Mar 2023 11:52:52 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On Mon, Mar 20, 2023 at 11:16:40AM -0600, Jens Axboe wrote:
> > diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
> > index f1fce1c7fa44b..c6c231f3d0f10 100644
> > --- a/block/blk-sysfs.c
> > +++ b/block/blk-sysfs.c
> > @@ -408,36 +408,7 @@ queue_rq_affinity_store(struct request_queue *q, const char *page, size_t count)
> >
> > static ssize_t queue_poll_delay_show(struct request_queue *q, char *page)
> > {
> > - int val;
> > -
> > - if (q->poll_nsec == BLK_MQ_POLL_CLASSIC)
> > - val = BLK_MQ_POLL_CLASSIC;
> > - else
> > - val = q->poll_nsec / 1000;
> > -
> > - return sprintf(page, "%d\n", val);
> > -}
> > -
> > -static ssize_t queue_poll_delay_store(struct request_queue *q, const char *page,
> > - size_t count)
> > -{
> > - int err, val;
> > -
> > - if (!q->mq_ops || !q->mq_ops->poll)
> > - return -EINVAL;
> > -
> > - err = kstrtoint(page, 10, &val);
> > - if (err < 0)
> > - return err;
> > -
> > - if (val == BLK_MQ_POLL_CLASSIC)
> > - q->poll_nsec = BLK_MQ_POLL_CLASSIC;
> > - else if (val >= 0)
> > - q->poll_nsec = val * 1000;
> > - else
> > - return -EINVAL;
> > -
> > - return count;
> > + return sprintf(page, "%d\n", -1);
> > }
>
> Do we want to retain the _store setting here to avoid breaking anything?
I was thinking users would want to know the kernel isn't going to honor the
requested value. Errors can already happen if you're using a stacked device, so
I assmued removing '_store' wouldn't break anyone using this interface.
But I can see it both ways though, so whichever you prefer. At the very least,
though, I need to update Documentation's sysfs-block, so I'll do that in the
v2.
next prev parent reply other threads:[~2023-03-20 17:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 16:12 [PATCH] blk-mq: remove hybrid polling Keith Busch
2023-03-20 17:16 ` Jens Axboe
2023-03-20 17:52 ` Keith Busch [this message]
2023-03-20 18:06 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox