public inbox for [email protected]
 help / color / mirror / Atom feed
From: Keith Busch <[email protected]>
To: Keith Busch <[email protected]>
Cc: [email protected], Jens Axboe <[email protected]>,
	[email protected], Pavel Begunkov <[email protected]>
Subject: Re: [PATCHv2] blk-mq: remove hybrid polling
Date: Mon, 20 Mar 2023 14:56:49 -0600	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On Mon, Mar 20, 2023 at 12:49:26PM -0700, Keith Busch wrote:
> From: Keith Busch <[email protected]>
> 
> io_uring provides the only way user space can poll completions, and that
> always sets BLK_POLL_NOSLEEP. This effectively makes hybrid polling dead
> code, so remove it and everything supporting it.

Hybrid polling was effectively killed off with 9650b453a3d4b1, "block: ignore
RWF_HIPRI hint for sync dio", so we could add a "Fixes: " for that. It was
still potentially reachable through io_uring until d729cf9acb93119, "io_uring:
don't sleep when polling for I/O", but hybrid polling probably should not have
been reachable through that async interface from the beginning.

  reply	other threads:[~2023-03-20 20:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-20 19:49 [PATCHv2] blk-mq: remove hybrid polling Keith Busch
2023-03-20 20:56 ` Keith Busch [this message]
2023-03-20 20:57   ` Jens Axboe
2023-03-20 20:59 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox